Use vmrun getGuestIPAddress to get IP (Big Sur) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
zarenner
reviewed
Mar 5, 2021
zarenner
approved these changes
Mar 5, 2021
|
Will this get merged in and released soon? |
|
@zarenner, is there anyway we can get this merged in and released? |
|
@smebberson I'm not a maintainer, just someone random who approved 😄. @frapposelli could you please take a look? |
|
if @frapposelli wanted to make me a maintainer, I'd be more than happy to test and merge, and maintain things going forward... |
|
done! thanks for your contribution @middagj ! @mikeroySoft happy to pass the baton to you Mike! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #30, which is needed for Big Sur.
I copied it from docker/machine#4847, with two minor changes. First I put the vmrun before mac, as it isn't needed with the
vmrun getGuestIPAddress. Secondly, I got rid of the capture group in the regex, as it is the same as the full full regex.