This repository has been archived by the owner on Sep 26, 2021. It is now read-only.
Use vmrun to find guest IP #4847
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there is no more vmnet devices on Big Sur, there's no DHCP lease update either. Find ip using vmrun's own feature first, falling back to the legacy ones next. Fixes docker#4846
zarenner
reviewed
Mar 5, 2021
| vmx := d.vmxPath() | ||
|
|
||
| ip := regexp.MustCompile(`(\d+\.\d+\.\d+\.\d+)`) | ||
| stdout, _, _ := vmrun("getGuestIPAddress", vmx) |
There was a problem hiding this comment.
I don't think this works in VMWare headless mode - there appears to be a bug that requires passing the -wait option to getGuestIPAddress otherwise it returns Error: The VMware Tools are not running in the virtual machine.
Also see machine-drivers/docker-machine-driver-vmware#31 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is no more vmnet devices on Big Sur, there's no DHCP lease update either. Find ip using vmrun's own feature first, falling back to the legacy ones next.
Fixes #4846