Transcode TXT field to dbus.Bytes for Python3 Avahi service #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In machinekit#324 it became obvious, that changes in how strings are represented in Python 3 from legacy Python 2 caused that request through DBus to Avahi were rejected. Python Avahi module includes function 'string_array_to_txt_array', which transcodes Python strings into byte arrays. Only used on the TXT value, as all others seem to be working. (Minimal changes to just get working system.)
cerna
force-pushed
the
python-avahi-service
branch
from
4d31c3d
to
07a6f10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements partial solution to the problem described in #324: