Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gdb vector registers support #49

Merged
merged 7 commits into from
Jun 26, 2023
Merged

Add gdb vector registers support #49

merged 7 commits into from
Jun 26, 2023

Conversation

SimonWin
Copy link
Contributor

No description provided.

Copy link
Contributor

@janweinstock janweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the issues mentioned inline. Note that I only marked the first occurrences of issues I found, there might be multiple locations that apply (e.g. use of vector::size and use of mkstr over setw)

src/vcml/debugging/gdbarch.cpp Show resolved Hide resolved
src/vcml/debugging/gdbarch.cpp Show resolved Hide resolved
src/vcml/debugging/gdbarch.cpp Show resolved Hide resolved
include/vcml/debugging/target.h Outdated Show resolved Hide resolved
src/vcml/debugging/gdbarch.cpp Outdated Show resolved Hide resolved
src/vcml/debugging/gdbarch.cpp Show resolved Hide resolved
src/vcml/debugging/gdbarch.cpp Outdated Show resolved Hide resolved
src/vcml/debugging/gdbserver.cpp Outdated Show resolved Hide resolved
src/vcml/debugging/gdbserver.cpp Outdated Show resolved Hide resolved
@janweinstock janweinstock merged commit a9f6155 into main Jun 26, 2023
@janweinstock janweinstock deleted the dev-gdb-vector-regs branch June 26, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants