Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.1.0 #4

Merged
merged 31 commits into from Aug 14, 2019
Merged

Release 0.1.0 #4

merged 31 commits into from Aug 14, 2019

Conversation

jcapona
Copy link
Collaborator

@jcapona jcapona commented Aug 14, 2019

Includes:

  • Re structure as python package
  • Create BaseSpider class from which all spiders should inherit from
  • Add unit testing

jcapona and others added 30 commits August 1, 2019 13:55
@jcapona
Use new file structure for packaging
559558e
@jcapona
Add manifest and setup script
a8edcc9
@jcapona
Update README
aab67e2
@jcapona
Add license
300b108
@jcapona
Update gitignore
7439fed
@jcapona
Fix MANIFEST command arguments
52f8dce
@jcapona
Fix package name in setup script
c42ab22
@jcapona
Clean package init file
424af58
@jcapona
Update setup script to add a testsuite
ccf4642
@jcapona
Merge pull request #1 from machinia/packaging
925af50 
Project packaging
@jcapona
Use multiprocessing process to perform scraping
6138dfa
@jcapona
Add tests for AmazonWishlishtSpider and code format
b9f406a
@jcapona
Add test description
1348639
@jcapona
Add yml file for Travis-CI integration
5821313
@jcapona
Add results file for any url test
7067d40
@jcapona
Filename/code formatting
f20ea7b
@jcapona
Change method for compatibility with OSX
62d7e02
@jcapona
Remove query string from URLs
37a67e8
@jcapona
Remove extra prints
97d4d54
@jcapona
Add coverage check on test run
35d1312
@jcapona
Add tests for util methods
5a9dc72
@jcapona
Fix max line length check on code format test
287825b
@jcapona
Merge pull request #2 from machinia/unit-testing
6eefcfa 
Unit testing
@jcapona
Add user agent to spider settings
07e1e22
@jcapona
Add SpiderBase class for all spiders to inherit
c4b7a20
@jcapona
Add/update tests
dbae788
@jcapona
Reorder imports
1e46820
@jcapona
Update gitignore
08e36b3
@jcapona
Merge pull request #3 from machinia/base-spider
f14a498 
Base Spider class
@jcapona
Update test
c903761
@jcapona jcapona requested a review from pahumadad August 14, 2019 21:25
@jcapona jcapona self-assigned this Aug 14, 2019
@jcapona jcapona changed the title Release 1.0.0 Release 0.1.0 Aug 14, 2019
pahumadad
pahumadad approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@pahumadad pahumadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcapona jcapona merged commit 81247a4 into master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pahumadad pahumadad pahumadad approved these changes

Assignees

@jcapona jcapona

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcapona @pahumadad