Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Spider class #3

Merged
merged 5 commits into from
Aug 14, 2019
Merged

Base Spider class #3

merged 5 commits into from
Aug 14, 2019

Conversation

jcapona
Copy link
Collaborator

@jcapona jcapona commented Aug 14, 2019

  • Add a BaseSpider class from which all spiders should inherit from
  • Add a user agent to spider settings

@jcapona jcapona requested a review from pahumadad August 14, 2019 14:28
@jcapona jcapona self-assigned this Aug 14, 2019
Copy link
Contributor

@pahumadad pahumadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@jcapona jcapona merged commit f14a498 into develop Aug 14, 2019
@jcapona jcapona deleted the base-spider branch August 14, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants