Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: summarize raising error when a grouping col is all NA (or mostly NA) #459

Merged
merged 5 commits into from Nov 16, 2022

Conversation

machow
Copy link
Owner

@machow machow commented Nov 16, 2022

Addresses #458, #251 by..

  • setting dropna=False, group_keys=True in group_by.
  • having summarize regroup with those arguments if necessary.
  • note that mutate sets group_keys=False to ensure group columns aren't put on the result twice.

@machow machow merged commit b1e1768 into main Nov 16, 2022
@machow machow deleted the fix-summarize-missing branch November 16, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant