Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise helpers should throw a TypeError, if they receive the wrong data structure #182

Closed
buschtoens opened this issue Oct 26, 2017 · 1 comment 路 Fixed by #313
Closed
Labels
enhancement has-pr Has a related pull request

Comments

@buschtoens
Copy link
Contributor

buschtoens commented Oct 26, 2017

It is so insidiously easy to forget [] when using all(). 馃槇

I've just spent 20 minutes debugging this piece of code:

yield all(
  this.verifyAddress(),
  this.verifyAge()
);

Can we please add proper type checks for these helper methods? I'm up for a PR!

@maxfierke
Copy link
Collaborator

Hi @buschtoens 馃憢 ! I'm going through the issue queue and hoping to close out any PRs that are stale. I know this is almost 2 years old, but are you still up for a PR on this one?

buschtoens added a commit to buschtoens/ember-concurrency that referenced this issue Aug 8, 2019
@maxfierke maxfierke added enhancement has-pr Has a related pull request labels Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement has-pr Has a related pull request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants