Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(promise-helpers): assert that argument is an array #313

Merged
merged 1 commit into from Sep 15, 2019

Conversation

buschtoens
Copy link
Contributor

Fixes #182.

FWIW ember-cli-sass / node-sass was giving me a major headache on my MacBook. I had to run as yarn --ignore-scripts to prevent the native node-sass build and then had to temporarily remove ember-cli-sass from the package.json in order to be able to start the test server.

I hope I didn't fuck up the yarn.lock. 馃槄

frankly, Sass needs to die in a fire... 馃敟

@buschtoens
Copy link
Contributor Author

/cc @maxfierke

Copy link
Collaborator

@maxfierke maxfierke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤 thumbs up from me. yarn.lock looks alright to me. test failure is def unrelated.

@maxfierke maxfierke merged commit ebe3380 into machty:master Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promise helpers should throw a TypeError, if they receive the wrong data structure
2 participants