Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glimmer components #272

Merged
merged 3 commits into from
May 9, 2016
Merged

Conversation

thec0keman
Copy link
Collaborator

@thec0keman thec0keman commented Apr 21, 2016

  • allows for block params and more advanced mustache on % syntax
  • adds deprecation API and deprecations for:
    • legacy Ember.View syntax
    • explicit mustache without =

Depends on #271 and #270

Fixes #240

@thec0keman
Copy link
Collaborator Author

@machty I could use your advice on how to move forward with this branch. I think the refactoring was important for making the glimmer component logic work, but it also helped clarify the overall logic a good deal for me. As a result, in the process of working on it it made several bug fixes trivial. (And unfortunately, it would take some extra work to backport them to a pre-refactor version).

I would really like to see the bugfixes and refactoring merged. As far as I know, the work on glimmer components is in line with the current syntax, but I don't think much more can be done until the Ember team finalizes that syntax. I think there is a good case for merging the current work, but with the obvious understanding that as the syntax finalizes some changes may need to be made.

What would you like to see from this branch to get it merged? If it would help I can split up this branch into its different parts (bugs, refactoring, etc.).

Thanks!

@machty
Copy link
Owner

machty commented May 8, 2016

@thec0keman could you e-mail me at machty@gmail.com? I'd like to discuss giving you commit bit for this repo :)

John Ratcliff added 3 commits May 8, 2016 18:23
- %dom syntax accepts block params and similar mustache params to explicit mustache
- added deprecation API
@thec0keman thec0keman merged commit ea5b539 into machty:master May 9, 2016
@thec0keman thec0keman deleted the glimmer-components branch May 9, 2016 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants