Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a user to associate an ephemeral public IPv4 address with the runner instance #57

Closed
wants to merge 2 commits into from

Conversation

jpalomaki
Copy link
Collaborator

@jpalomaki jpalomaki commented Jul 29, 2021

Useful in cases where a user wants to deploy the instance in a non-default public subnet (one for which automatic public IP assignment is disabled).

Should retain backwards compatibility (defaults to false).

Fixes #52.

@jpalomaki
Copy link
Collaborator Author

@machulav Do you have automated tests to test this with?

@jpalomaki jpalomaki changed the title Allow a user to associate a public IP with the runner instance Allow a user to associate an ephemeral public IPv4 address with the runner instance Jul 29, 2021
@jpalomaki jpalomaki marked this pull request as ready for review August 18, 2021 05:20
@jpalomaki jpalomaki marked this pull request as draft August 27, 2021 20:43
@jpalomaki
Copy link
Collaborator Author

jpalomaki commented Aug 28, 2021

Closing, in favor of leveraging EC2 launch templates to set spot network interface options (see #65)

@jpalomaki jpalomaki closed this Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to assign public ip to ec2 instance
1 participant