Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to run spot instances #62

Closed
wants to merge 1 commit into from

Conversation

jpalomaki
Copy link
Collaborator

@jpalomaki jpalomaki commented Aug 19, 2021

This would provide cost savings at the expense of reduced availability/reliability.

See https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-spot-instances.html

Backwards-compat as this would default to false.

Should fix #5

@jpalomaki
Copy link
Collaborator Author

@machulav This PR would also need some testing.

@jpalomaki jpalomaki marked this pull request as draft August 27, 2021 20:42
@jpalomaki
Copy link
Collaborator Author

jpalomaki commented Aug 27, 2021

@machulav I decided to draft my PRs (this one and #57) because I now feel we might want to explore the EC2 launch template facility first, prior to adding a bunch of new action inputs.

I've quickly tested the launch template approach in my own experimental action, and it seems to work fine. One can set spot, AMI, instance type etc options in a template and then just reference that template by ID or name, when launching the runner instance.

If you think the template approach could work, let me know and I can amend my set of PRs to use that instead.

@machulav
Copy link
Owner

That's a very interesting approach! Let me check that, and I will get back to you.

@machulav
Copy link
Owner

@jpalomaki I really like the idea of using the EC2 launch templates!

I see a lot of advantages in this approach:

  • Runner configuration is stored in one place controlled by the user.
  • AWS already provides all the configuration capabilities EC2 supports. A lot of them are already asked by our users in the issues. So we don't need to duplicate the same capabilities in the action.

As a result, we will have simpler and more stable action that is more flexible for the user!

However, we would need to introduce v3 with a changed approach to using the action. Which also may bring its own benefits.

Let's discuss the further details of this idea in the dedicated issue #65.

@jpalomaki
Copy link
Collaborator Author

jpalomaki commented Aug 28, 2021

Closing, in favor of leveraging EC2 launch templates to set spot options (see #65)

@jpalomaki jpalomaki closed this Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spot instances support
2 participants