Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AlertStatusOnGone in mackerel_monitor connectivity resource #218

Conversation

handlename
Copy link
Contributor

I added mackerel_monitor.connectivity.0.alert_status_on_gone to support AlertStatusOnGone for connectivity monitor.
https://mackerel.io/ja/api-docs/entry/monitors#create:~:text=%E3%83%AB%E3%83%BC%E3%83%AB%E3%81%AE%E3%83%A1%E3%83%A2%E3%80%82-,alertStatusOnGone,-string

Please review the code 馃檹

Output from acceptance testing:

$ make testacc TESTS=TestAccMackerelMonitor_Connectivity
TF_ACC=1 go test -v ./mackerel/... -run TestAccMackerelMonitor_Connectivity -timeout 120m
=== RUN   TestAccMackerelMonitor_Connectivity
=== PAUSE TestAccMackerelMonitor_Connectivity
=== CONT  TestAccMackerelMonitor_Connectivity
--- PASS: TestAccMackerelMonitor_Connectivity (6.38s)
PASS
ok  	github.com/mackerelio-labs/terraform-provider-mackerel/mackerel	6.765s

$ make testacc TESTS=TestAccDataSourceMackerelMonitorConnectivity
TF_ACC=1 go test -v ./mackerel/... -run TestAccDataSourceMackerelMonitorConnectivity -timeout 120m
=== RUN   TestAccDataSourceMackerelMonitorConnectivity
=== PAUSE TestAccDataSourceMackerelMonitorConnectivity
=== CONT  TestAccDataSourceMackerelMonitorConnectivity
--- PASS: TestAccDataSourceMackerelMonitorConnectivity (5.23s)
PASS
ok  	github.com/mackerelio-labs/terraform-provider-mackerel/mackerel	5.620s

@Arthur1 Arthur1 self-requested a review June 14, 2024 08:38
Copy link
Member

@Arthur1 Arthur1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that it works well. Thank you for your contribution!

@Arthur1 Arthur1 merged commit 73005a2 into mackerelio-labs:main Jun 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants