cut out cmdutil package from util and interface adjustment
#470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`env.ConvetToStrings` and assinment to `cmd.TimeoutDuraion` is always called after `config.parseCommand`, so for "DRY" do them inside `config.parseCommand`.
astj
approved these changes
Jan 10, 2018
| @@ -1,6 +1,4 @@ | |||
| // +build linux darwin freebsd netbsd windows | |||
There was a problem hiding this comment.
I wonder which platforms were excluded 🤔
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface of
util.RunCommandchanged at #460, but the interface here is cumbersome now, and since the package nameutilis not good at all, cut out into another packagecmdutiland adjust interface.