Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cut out cmdutil package from util and interface adjustment #470

Merged
merged 7 commits into from Jan 10, 2018
Merged

cut out cmdutil package from util and interface adjustment #470

merged 7 commits into from Jan 10, 2018

Commits on Jan 7, 2018

  1. add package cmdutil

    @Songmu
    Songmu committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    0376781 View commit details
    Browse the repository at this point in the history

  2. introduce cmdutil and remove util.RunCommand

    @Songmu
    Songmu committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    84220a1 View commit details
    Browse the repository at this point in the history

  3. Build config.Command inside config.parseCommand 

    `env.ConvetToStrings` and assinment to `cmd.TimeoutDuraion` is always called after `config.parseCommand`, so for "DRY" do them inside `config.parseCommand`.
    @Songmu
    Songmu committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    13d5247 View commit details
    Browse the repository at this point in the history

  4. embed into struct for DRY

    @Songmu
    Songmu committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    3c93f95 View commit details
    Browse the repository at this point in the history

  5. define config.CommandConfig.parse() and use it instead of using `pa… 

    …rseCommand`
    @Songmu
    Songmu committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    b46d0ba View commit details
    Browse the repository at this point in the history

  6. change cmdutil.RunCommand interface and follow it

    @Songmu
    Songmu committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    0a1fb64 View commit details
    Browse the repository at this point in the history

  7. minor adjustment in cmdutil/cmdutil.go

    @Songmu
    Songmu committed Jan 7, 2018
    Configuration menu
    Copy the full SHA
    da6fefd View commit details
    Browse the repository at this point in the history