Fixed to create configuration directory directory when executing init command if not exist directory #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomato3713
changed the title
tomato3713
changed the title
astj
reviewed
Sep 10, 2019
do_init.go
Outdated
| if !os.IsNotExist(err) { | ||
| return err | ||
| } | ||
| err := os.MkdirAll(root, 0744) |
There was a problem hiding this comment.
Is there any reason to choose 0744, not 0755?
Currently we use 0755 for newly created directories (explicitly in some cases, or implicitly in many cases). So I prefer 0755 here if there's no special reason.
There was a problem hiding this comment.
OK. thank you for reviewing
astj
approved these changes
Sep 11, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the configuration file directory does not exist,
executing
mackerel-agent init -apikey "api key "will return an error with no such file or directory.So, modified to create a directory if it doesn't exist when executing the above command,
And, add test code for not existing configuration directory.