-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add armhf Debian package to release #599
Conversation
0495141
to
85a1fcc
Compare
85a1fcc
to
fcd31f2
Compare
[memo]
|
Makefile
Outdated
@@ -103,6 +103,8 @@ crossbuild-package: deps | |||
mv build/$(MACKEREL_AGENT_NAME) build-linux-arm64/ | |||
GOOS=linux GOARCH=mips make build | |||
mv build/$(MACKEREL_AGENT_NAME) build-linux-mips/ | |||
GOOS=linux GOARCH=arm GOARM=6 make build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As "armhf" architecture, GOARM=7 is enough specification to build armhf-compatible, since "armhf" Debian supports >= ARMv7.
If you need ARMv6, the reason should be present in somewhere or different name than "armhf" should be used, to avoid confusion.
@hnw Thank you for pull request! Adding 32bit arm packages seems good, but maybe we need some discussion around GOARM parameter. Please check the review comment above. |
a3807ae
to
77786cd
Compare
Hi @astj. Thanks for the comment. I fixed a Docker image and added comments. As you mentioned above, ARMv6 is called as armhf on Raspbian (it's confusing but might be harmless because of upper compatibility). Raspberry Pi is widely used, so I'd like to support them. |
Sorry to have kept you waiting so long. LGTM! |
Add armhf(32bit ARM with hardfloat) Debian package support.
The package has already been tested in two weeks on my own Raspberry Pi 2, and it works fine.
However, this pull request has one problem. This change requires Docker image
yhnw/docker-mackerel-deb-builder
. We should use Docker image which is managed by Mackerel dev team.If the dev team approve mackerelio/docker-mackerel-deb-builder#1, then I'll fix the problem.