Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add armhf Debian package to release #599

Merged
merged 3 commits into from
Nov 6, 2019

Conversation

hnw
Copy link
Contributor

@hnw hnw commented Oct 21, 2019

Add armhf(32bit ARM with hardfloat) Debian package support.

The package has already been tested in two weeks on my own Raspberry Pi 2, and it works fine.

However, this pull request has one problem. This change requires Docker image yhnw/docker-mackerel-deb-builder. We should use Docker image which is managed by Mackerel dev team.

If the dev team approve mackerelio/docker-mackerel-deb-builder#1, then I'll fix the problem.

@astj
Copy link
Contributor

astj commented Oct 23, 2019

[memo]

Makefile Outdated
@@ -103,6 +103,8 @@ crossbuild-package: deps
mv build/$(MACKEREL_AGENT_NAME) build-linux-arm64/
GOOS=linux GOARCH=mips make build
mv build/$(MACKEREL_AGENT_NAME) build-linux-mips/
GOOS=linux GOARCH=arm GOARM=6 make build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As "armhf" architecture, GOARM=7 is enough specification to build armhf-compatible, since "armhf" Debian supports >= ARMv7.
If you need ARMv6, the reason should be present in somewhere or different name than "armhf" should be used, to avoid confusion.

@astj
Copy link
Contributor

astj commented Oct 23, 2019

@hnw Thank you for pull request! Adding 32bit arm packages seems good, but maybe we need some discussion around GOARM parameter. Please check the review comment above.

@hnw
Copy link
Contributor Author

hnw commented Oct 24, 2019

Hi @astj. Thanks for the comment.

I fixed a Docker image and added comments.

As you mentioned above, ARMv6 is called as armhf on Raspbian (it's confusing but might be harmless because of upper compatibility). Raspberry Pi is widely used, so I'd like to support them.

@astj
Copy link
Contributor

astj commented Nov 6, 2019

Sorry to have kept you waiting so long. LGTM!

@astj astj merged commit 08ea9e3 into mackerelio:master Nov 6, 2019
This was referenced Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants