Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add armhf Debian package to GitHub release #323

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

hnw
Copy link
Contributor

@hnw hnw commented Oct 18, 2020

Add armhf(32bit ARM with hardfloat) Debian/Raspberry Pi OS package support.

The package has already been tested on my own Raspberry Pi Zero, and it works fine.

@lufia lufia self-requested a review October 23, 2020 08:03
@lufia
Copy link
Member

lufia commented Oct 23, 2020

Hi @hnw

Thanks for your contribution! This changes is looks good.

We'd like to know where you need to publish this armhf package on:

  1. GitHub Release
  2. Official apt repository

Of course, the armhf package will be published on GitHub Release immediately after this p-r is merged and built whole the repository. However to publish it on official repository, we need to build mackerel-agent and plugins for armhf architecture, and to add more additional changes to internal codes for releasing.

Could are you satisfied if the armhf package of mkr is published GitHub Release?

@hnw
Copy link
Contributor Author

hnw commented Oct 25, 2020

I am intending "1", to publish on GitHub Realese.

As my understanding, the official apt repository provides official support packages by Hatena. And armhf architecture might be unofficial for business reason.

When I made a patch for armhf package of mackerel-agent (mackerelio/mackerel-agent#599), someone said it's difficult to include community packages into official repository. So, I suppose "2" is also hard for mkr.

@lufia
Copy link
Member

lufia commented Oct 26, 2020

Ok, I will merge this.

Again, thanks for your work.

@lufia lufia merged commit 15a49a2 into mackerelio:master Oct 26, 2020
@lufia
Copy link
Member

lufia commented Oct 26, 2020

Ah, sorry. I said "published on GitHub Release immediately after this p-r is merged and built whole the repository." but that is wrong. We will release new version of mkr in few days. Please wait a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants