Fix config test #830

ryuichi1208 · 2022-11-05T08:30:29Z

refs: #829

# befor
[WARNING] plugin.metrics.aaa.action.max_check_attempts is unexpected key. did you mean plugin.metrics.aaa.action.max_check_attempts ?

# after
[WARNING] plugin.metrics.aaa.action.max_check_attempts is unexpected key.

Arthur1

@ryuichi1208

Thank you for your pull request! We merge this and release it, as this simple diff would resolve the issue #829 .

By the way, we are aware of the problem that the entire logic of key suggestion is complex. Please note that we may change the code around this in the near future.

Arthur1 · 2022-11-09T04:32:16Z

config/validate.go

@@ -55,7 +56,9 @@ func nameSuggestion(given string, candidates []string) string {
 	for _, candidate := range candidates {
 		dist := levenshtein.Distance(given, candidate, nil)
 		if dist < 3 {
-			return candidate
+			if candidate != given {


[nit] The comparison candidate != given could be described succinctly using the Levenshtein distance.

ryuichi1208 added 3 commits November 5, 2022 17:29

Correct output of validate result

b1cda9c

add test case

73201ed

del fmt

6b4dc17

Arthur1 self-requested a review November 7, 2022 06:32

Arthur1 approved these changes Nov 9, 2022

View reviewed changes

Arthur1 merged commit c13184b into mackerelio:master Nov 9, 2022

mackerelbot mentioned this pull request Nov 9, 2022

Release version 0.73.3 #833

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix config test #830

Fix config test #830

ryuichi1208 commented Nov 5, 2022 •

edited

Arthur1 left a comment

Arthur1 Nov 9, 2022

Fix config test #830

Fix config test #830

Conversation

ryuichi1208 commented Nov 5, 2022 • edited

Arthur1 left a comment

Choose a reason for hiding this comment

Arthur1 Nov 9, 2022

Choose a reason for hiding this comment

ryuichi1208 commented Nov 5, 2022 •

edited