Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Makefile #200

Merged
merged 4 commits into from
Mar 22, 2019
Merged

Improve Makefile #200

merged 4 commits into from
Mar 22, 2019

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Mar 20, 2019

  • Add -w -s in make cross too.
  • Move phony targets (ref: Clark Grubb's Makefile style guide)
  • := is preferred than = in performance (especially when referred multiple times)

Before

~/.go/src/github.com/mackerelio/mkr ls -lh snapshot/
total 66824
-rw-r--r--  1 itchyny  staff   7.5M Mar 20 17:42 mkr_darwin_386.zip
-rw-r--r--  1 itchyny  staff   7.7M Mar 20 17:42 mkr_darwin_amd64.zip
-rw-r--r--  1 itchyny  staff   7.6M Mar 20 17:42 mkr_linux_386.tar.gz
-rw-r--r--  1 itchyny  staff   7.7M Mar 20 17:42 mkr_linux_amd64.tar.gz

After

~/.go/src/github.com/mackerelio/mkr ls -lh snapshot/
total 37936
-rw-r--r--  1 itchyny  staff   4.5M Mar 20 17:59 mkr_darwin_386.zip
-rw-r--r--  1 itchyny  staff   4.7M Mar 20 17:59 mkr_darwin_amd64.zip
-rw-r--r--  1 itchyny  staff   4.2M Mar 20 17:59 mkr_linux_386.tar.gz
-rw-r--r--  1 itchyny  staff   4.4M Mar 20 17:59 mkr_linux_amd64.tar.gz

@itchyny itchyny changed the title Improve makefile Improve Makefile Mar 20, 2019
@itchyny itchyny merged commit 011fc3e into master Mar 22, 2019
@itchyny itchyny deleted the improve-makefile branch March 22, 2019 01:28
@lufia lufia mentioned this pull request Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants