Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formatter.NewAsciiFormatter now needs config #80

Merged
merged 1 commit into from
Jan 10, 2017
Merged

formatter.NewAsciiFormatter now needs config #80

merged 1 commit into from
Jan 10, 2017

Conversation

astj
Copy link
Contributor

@astj astj commented Jan 10, 2017

ref: yudai/gojsondiff@7b1b7ad

(Maybe we need to introduce some version lock for dependencies like vendoring?)

haya14busa
haya14busa approved these changes Jan 10, 2017
View reviewed changes
Copy link
Contributor

@haya14busa haya14busa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@astj
Copy link
Contributor Author

astj commented Jan 10, 2017

Thanks!

@astj astj merged commit a0a6c91 into master Jan 10, 2017
@astj astj deleted the deal-with-jsondiff-update branch January 10, 2017 02:08
@stanaka stanaka mentioned this pull request Jan 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haya14busa haya14busa haya14busa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astj @haya14busa