dr_flac: Remove comparison that is always true #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparison is always true, because code above returns early when unsigned blockSize is 0. This invariant is asserted just before if-else chain.
|
Thanks. Merged to the dev branch. |
|
All three
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparison is always true, because code above returns early when
unsigned blockSize is 0. This invariant is asserted just before
if-else chain.
This is a follow up to #176 - to present an alternative fix. I also experimented with replacing these if-else's with a switch statement, but replacing this single comparison with an assert is less invasive change, and more readable.