Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build against OpenSSL version 1.1.0g #18

Open
erikd opened this issue Dec 31, 2017 · 11 comments
Open

Fails to build against OpenSSL version 1.1.0g #18

erikd opened this issue Dec 31, 2017 · 11 comments

Comments

@erikd
Copy link

erikd commented Dec 31, 2017

#Configure fails at:

checking openssl/evp.h usability... yes
checking openssl/evp.h presence... yes
checking for openssl/evp.h... yes
checking for OpenSSL_add_all_ciphers in -lcrypto... no
configure: error: Cannot build without libcrypto (OpenSSL)
Error 0 in ./configure

I have OpenSSL version 1.1.0g instatlled.

I'd fix this, but I'm already to deep down the yak stack.

@eshwarz
Copy link

eshwarz commented Mar 19, 2018

@erikd do we have a work around for this?

@erikd
Copy link
Author

erikd commented Mar 19, 2018

We? I don't. No idea if anyone else does.

@armijnhemel
Copy link

In OpenSSL 1.1.x the function OpenSSL_add_all_ciphers was deprecated and replaced with OPENSSL_init_crypto:

https://www.openssl.org/docs/man1.1.0/crypto/OpenSSL_add_all_ciphers.html

in configure.ac I replaced the OpenSSL_add_all_ciphers line with this:

AC_CHECK_LIB([crypto], [OPENSSL_init_crypto], , [have_libcrypto="0"])

then reran autogen.sh and that fixes the build for me on Fedora 26. At first glance xar seems to run fine.

@erikd
Copy link
Author

erikd commented Apr 9, 2018

@armijnhemel Would be great if could you raise a PR with those changes.

@armijnhemel
Copy link

I will first need to run a few more tests to see if it actually works as expected before I create a PR. Also, this change will break building with openssl 1.0.x and I would also need to work around that.

@erikd
Copy link
Author

erikd commented Apr 10, 2018

Obviously, this is not my project, but I honestly don't think backwards compatibility with an older version of OpenSSL is an important factor. OpenSSL is an important security related library with a somewhat checkered history security wise. Supporting old, possible broken versions doesn't make a lot of sense, especially since 1.1.* has been out for for over a year. See https://www.openssl.org/news/openssl-1.1.0-notes.html

@janpio
Copy link

janpio commented Sep 11, 2018

The change @ErikGoldman did here https://github.com/loft-box-labs/xar/commit/bab8837fd993385115d58763e15487dc8cc13f97 (probably via #18 (comment)) worked perfectly for me.

Schamschula pushed a commit to macports/macports-ports that referenced this issue Mar 7, 2019
OpenSSL 1.1.0 deprecated OpenSSL_add_all_algorithms and replaced with
OPENSSL_init_crypto.

Ref: mackyle/xar#18
Ref: https://trac.macports.org/ticket/52101
ericwilson29 added a commit to ericwilson29/xar that referenced this issue Aug 31, 2019
ludwhe pushed a commit to ludwhe/xar that referenced this issue Apr 14, 2020
@jds11111
Copy link

This is still broken, or possibly broken again. I have followed the suggestions her, but still missing libcrypto. I suspect that it is because the standard version for Ubuntu 18.04 is now openssl v1.1.1.g and the dev library is just 1.1

@baryluk
Copy link

baryluk commented Nov 17, 2020

Same here on Debian testing. I have libssl-dev 1.1.1h-1 and libcrypt-dev 1:4.4.17-1 installed. No progress.

@ckujau
Copy link

ckujau commented Nov 18, 2020

The last commit to the master branch has been made in 2014 - I guess this project is no longer active and the chances that one of the proposed pull requests will ever be merged are pretty thin. @mackyle Do you have an update on the project status? Please? :-D

@palmerc
Copy link

palmerc commented Mar 29, 2022

I used LibreSSL built locally since it is OpenSSL v1.0.0 compatible. It is pretty simple to build because it uses CMake, then I just install in a local directory and pass the CFLAGS and LDFLAGS to the ./configure command

typeling1578 added a commit to typeling1578/xar that referenced this issue Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants