New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build against OpenSSL version 1.1.0g #18

Open
erikd opened this Issue Dec 31, 2017 · 7 comments

Comments

Projects
None yet
4 participants
@erikd

erikd commented Dec 31, 2017

#Configure fails at:

checking openssl/evp.h usability... yes
checking openssl/evp.h presence... yes
checking for openssl/evp.h... yes
checking for OpenSSL_add_all_ciphers in -lcrypto... no
configure: error: Cannot build without libcrypto (OpenSSL)
Error 0 in ./configure

I have OpenSSL version 1.1.0g instatlled.

I'd fix this, but I'm already to deep down the yak stack.

@eshwarz

This comment has been minimized.

Show comment
Hide comment
@eshwarz

eshwarz Mar 19, 2018

@erikd do we have a work around for this?

eshwarz commented Mar 19, 2018

@erikd do we have a work around for this?

@erikd

This comment has been minimized.

Show comment
Hide comment
@erikd

erikd Mar 19, 2018

We? I don't. No idea if anyone else does.

erikd commented Mar 19, 2018

We? I don't. No idea if anyone else does.

@armijnhemel

This comment has been minimized.

Show comment
Hide comment
@armijnhemel

armijnhemel Apr 9, 2018

In OpenSSL 1.1.x the function OpenSSL_add_all_ciphers was deprecated and replaced with OPENSSL_init_crypto:

https://www.openssl.org/docs/man1.1.0/crypto/OpenSSL_add_all_ciphers.html

in configure.ac I replaced the OpenSSL_add_all_ciphers line with this:

AC_CHECK_LIB([crypto], [OPENSSL_init_crypto], , [have_libcrypto="0"])

then reran autogen.sh and that fixes the build for me on Fedora 26. At first glance xar seems to run fine.

armijnhemel commented Apr 9, 2018

In OpenSSL 1.1.x the function OpenSSL_add_all_ciphers was deprecated and replaced with OPENSSL_init_crypto:

https://www.openssl.org/docs/man1.1.0/crypto/OpenSSL_add_all_ciphers.html

in configure.ac I replaced the OpenSSL_add_all_ciphers line with this:

AC_CHECK_LIB([crypto], [OPENSSL_init_crypto], , [have_libcrypto="0"])

then reran autogen.sh and that fixes the build for me on Fedora 26. At first glance xar seems to run fine.

@erikd

This comment has been minimized.

Show comment
Hide comment
@erikd

erikd Apr 9, 2018

@armijnhemel Would be great if could you raise a PR with those changes.

erikd commented Apr 9, 2018

@armijnhemel Would be great if could you raise a PR with those changes.

@armijnhemel

This comment has been minimized.

Show comment
Hide comment
@armijnhemel

armijnhemel Apr 9, 2018

I will first need to run a few more tests to see if it actually works as expected before I create a PR. Also, this change will break building with openssl 1.0.x and I would also need to work around that.

armijnhemel commented Apr 9, 2018

I will first need to run a few more tests to see if it actually works as expected before I create a PR. Also, this change will break building with openssl 1.0.x and I would also need to work around that.

@erikd

This comment has been minimized.

Show comment
Hide comment
@erikd

erikd Apr 10, 2018

Obviously, this is not my project, but I honestly don't think backwards compatibility with an older version of OpenSSL is an important factor. OpenSSL is an important security related library with a somewhat checkered history security wise. Supporting old, possible broken versions doesn't make a lot of sense, especially since 1.1.* has been out for for over a year. See https://www.openssl.org/news/openssl-1.1.0-notes.html

erikd commented Apr 10, 2018

Obviously, this is not my project, but I honestly don't think backwards compatibility with an older version of OpenSSL is an important factor. OpenSSL is an important security related library with a somewhat checkered history security wise. Supporting old, possible broken versions doesn't make a lot of sense, especially since 1.1.* has been out for for over a year. See https://www.openssl.org/news/openssl-1.1.0-notes.html

ErikGoldman added a commit to loft-box-labs/xar that referenced this issue May 1, 2018

aque added a commit to aque/macports-ports that referenced this issue Aug 4, 2018

xar: patch deprecated openssl function
OpenSSL 1.1.0 deprecated OpenSSL_add_all_algorithms and replaced with
OPENSSL_init_crypto.

Ref: mackyle/xar#18

aque added a commit to aque/macports-ports that referenced this issue Aug 4, 2018

xar: patch deprecated openssl function
OpenSSL 1.1.0 deprecated OpenSSL_add_all_algorithms and replaced with
OPENSSL_init_crypto.

Ref: mackyle/xar#18

aque added a commit to aque/macports-ports that referenced this issue Aug 4, 2018

xar: patch deprecated openssl function
OpenSSL 1.1.0 deprecated OpenSSL_add_all_algorithms and replaced with
OPENSSL_init_crypto.

Ref: mackyle/xar#18

aque added a commit to aque/macports-ports that referenced this issue Sep 2, 2018

xar: patch deprecated openssl function
OpenSSL 1.1.0 deprecated OpenSSL_add_all_algorithms and replaced with
OPENSSL_init_crypto.

Ref: mackyle/xar#18
@janpio

This comment has been minimized.

Show comment
Hide comment
@janpio

janpio Sep 11, 2018

The change @ErikGoldman did here loft-box-labs@bab8837 (probably via #18 (comment)) worked perfectly for me.

janpio commented Sep 11, 2018

The change @ErikGoldman did here loft-box-labs@bab8837 (probably via #18 (comment)) worked perfectly for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment