Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info on https://ports.macports.org to buildbot section, #63001 #45

Merged
merged 1 commit into from Sep 15, 2022

Conversation

JDLH
Copy link

@JDLH JDLH commented May 31, 2021

In no particular order:

  • Guide section 4.8. "MacPorts' buildbot" did not mention the web page at https://ports.macports.org/ at all. Add a one-paragraph summary of what this page can do for port developers to the end of the section.
  • Also, the previous part of the section mentioned the "waterfall" and "builders" pages on the https://build.macports.org web page, but did not
    mention the URL itself. So I added that URL.
  • Re-sequence the sentences to soften the claim that these views are "most useful", since I don't think these views are as good as the ports.macports.org page.

This addresses Trac ticket #63001, "Guide: add description of web app at ports.macports.org", https://trac.macports.org/ticket/63001 .

Guide section 4.8. "MacPorts' buildbot" did not mention the web page
at https://ports.macports.org/ at all. Add a one-paragraph summary of
what this page can do for port developers to the end of the section.

Also, the previous part of the section mentioned the "waterfall" and
"builders" pages on the https://build.macports.org web page, but did not
mention the URL itself. So I added that URL. Also resequence the
sentences to soften the claim that these views are "most useful", since
I don't think these views are as good as the ports.macports.org page.

This addresses Trac ticket #63001, "Guide: add description of web app
at ports.macports.org", https://trac.macports.org/ticket/63001 .
Copy link
Member

@mascguy mascguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Anyone else?

@mascguy
Copy link
Member

mascguy commented Sep 15, 2022

This all looks good, and is a nice improvement. Merging.

@mascguy mascguy merged commit 9a1d2f2 into macports:master Sep 15, 2022
@mascguy
Copy link
Member

mascguy commented Sep 15, 2022

And thanks for your various PRs Jim, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants