Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pg app 1.1: new version, utilizing callback mechanism #16148

Merged
merged 3 commits into from
Sep 22, 2022
Merged

pg app 1.1: new version, utilizing callback mechanism #16148

merged 3 commits into from
Sep 22, 2022

Conversation

mascguy
Copy link
Member

@mascguy mascguy commented Sep 17, 2022 •
edited
Loading

Description

The background behind this, is available in the associated ticket:

Tested with port Gramps, included with this PR, to validate.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer maintainer: open Affects an openmaintainer port labels Sep 17, 2022
@macports macports deleted a comment from macportsbot Sep 17, 2022
@mascguy
Copy link
Member Author

mascguy commented Sep 17, 2022 •
edited
Loading

Reviewers: I tried to keep everything as similar as possible between the old and new pg, with some minor exceptions:

  • Everything is now scoped to namespace app.
  • For cases where there's notable copy-pasta - such as for paths - that was cleaned up.
  • The trace on app.icon was removed. If there's an interest in maintaining that, we can do so via an option proc.

@mascguy mascguy merged commit 1e5eb94 into macports:master Sep 22, 2022
@mascguy mascguy deleted the mascguy-pg-app branch September 22, 2022 13:43
mascguy added a commit that referenced this pull request Sep 22, 2022
@mascguy
gramps: rev-bump for app pg update
17eeaed 
See: #16148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mojca mojca Awaiting requested review from mojca

@ryandesign ryandesign Awaiting requested review from ryandesign

@jmroot jmroot Awaiting requested review from jmroot

Assignees
No one assigned
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port maintainer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mascguy @dbevans @macportsbot