-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minetest-devel: new port in games #17080
Conversation
MT 5.6.1 minetest-devel derived from minetest * Portfile derived from minetest port * updates and additions to 'depends_lib-append' * updates and additions to 'configure.args-append' * includes all diiffs from minetest * adds new maintainer + license EUPL-1.2 * adds 'conflicts minetest' Ref https://trac.macports.org/ticket/66562
The rationale why to establish a new minetest-devel port parallel to the minetest legacy port.
IMO this should be sufficient. There may be more reasons in addition. Please note I volunteer in becoming maintainer to both ports. Hope this helps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the submission @Zweihorn. A few comments below - in addition I wonder whether this can be just a subport of the "minetest" Portfile as presumably both ports will share many of the same content.
@reneeotten - Please see #17080 (comment) which reads above in this PR obviously. Additionally, I would fear that most MT users just want to be MT players and I want to avoid any intro barriers for them. The concept of variants might be clear to experts but I learned of so many innocence in the MT forums recently that I would fear to drive people away. So let me stick with this approach of two parallel ports for the near future please. However, after some months (while getting some more awareness and replies from MT players after the implementation of the minetest-devel first) in better establishing myself as maintainer I will be happy to re-consider your proposal. What do you think of this? Deal? |
* license is `LGPL`now * new maintainer by GitHub only
@reneeotten - THX Again I highly appreciate your commitment in guiding me through this. |
Addendum: I reconsidered your proposal to keep with one port only and found a loop-hole in my thinking.
@reneeotten - Change of mind: I happily agree to maintain just the |
Oopsy. Now there is the need in moving the content of the improved Portfile from this PR to Stay tuned . . . |
This PR was made obsolete by #17077 and thus will be closed accordingly. |
This PR became obsolete by #17077 and was closed.
MT 5.6.1 minetest-devel derived from minetest
EUPL-1.2
<--- changed back toLGPL
to resolve conversationRef https://trac.macports.org/ticket/66562
Description
MT 5.6.1 minetest-devel provides better compatibility with other ports and greatly improves the internal performance of the Minetest App by providing particular options to the build of the port.
The Portfile Depends.Lib were improved for compatibility in general. The two more particular additions were:
SQLite3 was made the default database back-end by the MT project since 0.4.17 or earlier. Accordingly, the a.m. dependency avoids a default at the legacy sqlite3 from the OS by Apple.
The Portfile Config.Args were improved on particular CMake options for the MT build:
Apparently, these options were missed in establishing the legacy minetest port definitions in the past.
Further Improvements to the Portfile and the Verification output can be found in the Addendum below.
However, I decline to publicly distributing my personal email address.
Needs further application on 7.6. MacPorts Membership for my
macports.org:Zweihorn
email by your kind approval.Please be aware, my work and/or contribution to Open Source Endeavour is always published under the EUPL-1.2 license. This fits my legal requirement as an European citizen thus outside U.S. jurisdiction. Furthermore, the Open Source Initiative (OSI) approves of EUPL-1.2 and agrees, that public domain doesn't exist in Europe.
Type(s)
Tested on
macOS 11.7.2 20G1020 x86_64
Command Line Tools 13.2.0.0.1.1638488800
Verification
We have successfully verified as follows:
port lint --nitpick
? - for output see belowsudo port test
? - for output see belowsudo port -vst install
? - for output see belowAddendum
Minetest 5.6.1 minetest-devel results and improvements to Portfile
Portfile check
Acceptable results.
The warning derives from the
set game_version 5.6.1
which cannot be avoided due to technical reasons.There is the need to give both the MT core and the MT game a version number each respectively as these may differ.
NO existing tests
There were no tests turned on.
IMO the errors can be neglected due to tests turned off obviously. No bug.
Full install
Tested basic functionality
Minetest 5.6.1 minetest-devel was started via the MT App from the LaunchPad successfully.
Minetest 5.6.1 minetest-devel was started and uses SQLite3 as default Database Back-end.
NOTE: For the MT graphical world view see the PNG in the attach.
Improvements to the Portfile
This is a Diff-file amended by inline commentary for explanations.
Particular POIs are marked with
<-- # better compatibility
or similar comment inline.Last not least this Portfile was implemented as a local port definition on may Mac for years and greatly improving my user experience as a MT player together with the MT server even for several Multi-Player events. The code build can be called stable, I presume.
Hope this helps.
Licence
@Zweihorn - 2022-12-27
This work is derived from work under the LGPL-1.2+ from 'minetest' on MacPorts ports.
Licensed under the EUPL-1.2-or-later
The text of the European Union Public Licence (EUPL) version 1.2,
published in Official Journal of 19 May 2017 and available in 23
official languages of the European Union (SPDX identifier EUPL-1.2),
is to be found at:
The a.m. page contains all the official versions of the European Union
Public Licence (EUPL-1.2). The preamble written for v 1.0, explaining
the purpose of this Free/Open Source Software Licence, together with
links to further information on the licence is valid for later versions.
The Joinup Licensing Assistant (JLA) may be worth a visit to find and
compare software licenses with:
The JLA is linked to SPDX (for Software Package Data Exchange), an
initiative of the LINUX foundation that attempts to standardize the way
in which organizations refer to software licenses: each licence is
identified by a full name, such as "European Union Public Licence 1.2"
and a shorter identifier, here "EUPL-1.2".
MT graphical world view