-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py-idna-ssl: new port, version 1.0.1 #2001
Conversation
python/py-idna-ssl/Portfile
Outdated
maintainers {ipglider.org:miguel @ipglider} openmaintainer | ||
|
||
description Patch ssl.match_hostname for Unicode(idna) domains support | ||
long_description Patch ssl.match_hostname for Unicode(idna) domains support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably be better to have a long description that described the port a bit better. I have no idea what it does given the current one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, having looked at https://pypi.org/project/idna_ssl/ I still have no idea what this does. (The description there is, as I'm sure you know, identical...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Python library idna does not work as expected when using SSL under some versions of the interpreter.
aiohttp depends on idna-ssl to solve this problem. More info in aio-libs/aiohttp#949.
I will change the description to be more useful. Thank you for taking the time to review my PRs.
Travis Build #2584 Passed. Lint results
Port py-idna-ssl success on xcode9.3. Log |
Travis Build #2586 Passed. Lint results
Port py-idna-ssl success on xcode9.3. Log |
Thanks for your contributions to MacPorts, @IPGlider! |
Description
Type(s)
Tested on
macOS 10.13.5 17F77
Xcode 9.4 9F1027a
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
?