Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py-idna-ssl: new port, version 1.0.1 #2001

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Conversation

IPGlider
Copy link
Contributor

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.13.5 17F77
Xcode 9.4 9F1027a

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

maintainers {ipglider.org:miguel @ipglider} openmaintainer

description Patch ssl.match_hostname for Unicode(idna) domains support
long_description Patch ssl.match_hostname for Unicode(idna) domains support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be better to have a long description that described the port a bit better. I have no idea what it does given the current one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, having looked at https://pypi.org/project/idna_ssl/ I still have no idea what this does. (The description there is, as I'm sure you know, identical...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python library idna does not work as expected when using SSL under some versions of the interpreter.

aiohttp depends on idna-ssl to solve this problem. More info in aio-libs/aiohttp#949.

I will change the description to be more useful. Thank you for taking the time to review my PRs.

@macportsbot
Copy link

Travis Build #2584 Passed.

Lint results
Warning: Failed to copy com.apple.dt.Xcode.plist to /opt/local/var/macports/home/Library/Preferences: could not set owner for file "/opt/local/var/macports/home/Library/Preferences/com.apple.dt.Xcode.plist": no such file or directory
--->  Verifying Portfile for py-idna-ssl
--->  0 errors and 0 warnings found.

Port py-idna-ssl success on xcode9.3. Log
Port py34-idna-ssl success on xcode9.3. Log
Port py35-idna-ssl success on xcode9.3. Log
Port py36-idna-ssl success on xcode9.3. Log
Port py-idna-ssl success on xcode8.3. Log
Port py34-idna-ssl success on xcode8.3. Log
Port py35-idna-ssl success on xcode8.3. Log
Port py36-idna-ssl success on xcode8.3. Log
Port py-idna-ssl success on xcode7.3. Log
Port py34-idna-ssl success on xcode7.3. Log
Port py35-idna-ssl success on xcode7.3. Log

@macportsbot
Copy link

Travis Build #2586 Passed.

Lint results
--->  Verifying Portfile for py-idna-ssl
--->  0 errors and 0 warnings found.

Port py-idna-ssl success on xcode9.3. Log
Port py34-idna-ssl success on xcode9.3. Log
Port py35-idna-ssl success on xcode9.3. Log
Port py36-idna-ssl success on xcode9.3. Log
Port py-idna-ssl success on xcode8.3. Log
Port py34-idna-ssl success on xcode8.3. Log
Port py35-idna-ssl success on xcode8.3. Log
Port py36-idna-ssl success on xcode8.3. Log
Port py-idna-ssl success on xcode7.3. Log
Port py34-idna-ssl success on xcode7.3. Log
Port py35-idna-ssl success on xcode7.3. Log
Port py36-idna-ssl success on xcode7.3. Log

@pmetzger pmetzger merged commit 4b61abb into macports:master Jun 11, 2018
@pmetzger
Copy link
Member

Thanks for your contributions to MacPorts, @IPGlider!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants