Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qgis3, PDAL, postgis3: update #20178

Merged
merged 5 commits into from
Aug 29, 2023
Merged

qgis3, PDAL, postgis3: update #20178

merged 5 commits into from
Aug 29, 2023

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Aug 27, 2023

Description

Update qgis3 to 3.32.2, qgis3-ltr to 3.28.10, PDAL to 2.5.6 and postgis3 to 3.4.0.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 12.6.6 21G646 arm64
Xcode 14.2 14C18

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@Veence for port postgis3, qgis3, saga.

@@ -26,23 +26,23 @@ subport ${name-ltr} {}

if {${subport} eq ${name}} {
# Latest version
github.setup qgis QGIS 3_32_1 final-
github.setup qgis QGIS 3_32_2 final-
revision 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the revision should be reset to 0 when updating the version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed these ones, fixed. Thanks!

} else {
# LTR version
github.setup qgis QGIS 3_28_9 final-
github.setup qgis QGIS 3_28_10 final-
revision 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@nilason
Copy link
Contributor Author

nilason commented Aug 28, 2023

Added a commit with a new qgis3 default variant for better support of plugins (see https://trac.macports.org/ticket/68016#comment:5).

@nilason
Copy link
Contributor Author

nilason commented Aug 29, 2023

Added a commit with a new qgis3 default variant for better support of plugins (see https://trac.macports.org/ticket/68016#comment:5).

Should add I didn't include the new dependencies for the new plugin_support variant completely out of the blue. I did a conservative selection based on https://github.com/qgis/QGIS-Mac-Packager, https://www.freshports.org/graphics/qgis and https://sources.debian.org/src/qgis/3.28.10%2Bdfsg-1/debian/ .

@reneeotten
Copy link
Contributor

thanks @nilason, looks good to me! I guess the only question is whether this should be a default variant, but that's up to the maintainer. What do other package managers do?

@nilason
Copy link
Contributor Author

nilason commented Aug 29, 2023

thanks @nilason, looks good to me! I guess the only question is whether this should be a default variant, but that's up to the maintainer. What do other package managers do?

The official Mac bundle and FreeBSD go all in without question (installs all plugin dependencies right away), I guess that is what the general user expect (hence the number of new tickets). With a default variant we achieve something similar, but with the possibility to opt out.
The dependencies are all python modules so I guess the size isn't much of an issue.

@reneeotten reneeotten merged commit c84eeb9 into macports:master Aug 29, 2023
3 checks passed
@nilason
Copy link
Contributor Author

nilason commented Aug 29, 2023

Thank you @reneeotten !

@nilason nilason deleted the gis_update branch August 30, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants