Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libressl: fix build on macOS < 10.14 #21539

Conversation

aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor

Closes: https://trac.macports.org/ticket/68770

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8 10K549 x86_64
Xcode 3.2.6 10M2518

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@neverpanic for port libressl.
@artkiver for port libressl.

@macportsbot macportsbot added the maintainer: open Affects an openmaintainer port label Nov 26, 2023
@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor Author

These changes should be synchronized with libressl-devel portfile, but I'm assigning that job to @artkiver; I also want to see how this works on other buildbots.

Copy link
Member

@neverpanic neverpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M, but let's wait for @artkiver to provide feedback.

@artkiver
Copy link
Contributor

LG2M, but let's wait for @artkiver to provide feedback.

I don't have older systems running those versions of OS X and XCode to test at the moment, but I will take your word that this is tested and functioning there.

Thank you for the improvement! I'm happy to make changes to the libressl-devel Portfile as well, though again I won't be able to do much testing on my end with my present resources (possibly I could try spinning up a VM on an older laptop, but that will take me some time).

@artkiver
Copy link
Contributor

I submitted a PR to update libressl-devel here: #21556

Basically just copy and pasted the pertinent changes for the Portfile based upon this PR, but as stated previously I do not at the moment have an older OS X system running < 10.14 to test; but I am guessing it is OK?

Thank you again to @aeiouaeiouaeiouaeiouaeiouaeiou for the improvements!

@TheRealKeto
Copy link
Contributor

I decided to test this change and it seems to have built just fine on macOS 10.7.5 11G63 x86_64 running Xcode 4.6.3 4H1503.

@herbygillot herbygillot merged commit 16f1860 into macports:master Nov 27, 2023
3 checks passed
@aeiouaeiouaeiouaeiouaeiouaeiou aeiouaeiouaeiouaeiouaeiouaeiou deleted the libressl-clang-update branch November 27, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port
6 participants