Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libressl-devel: fix build on macOS < 10.14 #21556

Merged
merged 1 commit into from Nov 27, 2023

Conversation

artkiver
Copy link
Contributor

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 14.2 23C5047e arm64
Xcode 15.0 15A5219j

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@neverpanic for port libressl-devel.

@TheRealKeto
Copy link
Contributor

I decided to test this change and it seems to have built just fine on macOS 10.7.5 11G63 x86_64 running Xcode 4.6.3 4H1503. No errors to report.

@herbygillot herbygillot merged commit f74268b into macports:master Nov 27, 2023
3 checks passed
@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor

@artkiver @TheRealKeto @ryandesign buildbot keeps failing because it can't uninstall openssl...

@TheRealKeto
Copy link
Contributor

buildbot keeps failing because it can't uninstall openssl...

@aeiouaeiouaeiouaeiouaeiouaeiou openssl should also conflict with libressl{,-devel}; I don't know what openssl is installed for, but it should also have a conflict statement

@artkiver
Copy link
Contributor Author

I decided to test this change and it seems to have built just fine on macOS 10.7.5 11G63 x86_64 running Xcode 4.6.3 4H1503. No errors to report.

Thank you @TheRealKeto for going the extra mile and testing this on Lion! 🙏

Also thank you to @herbygillot for merging this.

Regarding the build failing on the buildbots as @aeiouaeiouaeiouaeiouaeiouaeiou indicated, that is confusing to me as well since as @TheRealKeto correctly pointed out the Portfile has the following conflicts line:

conflicts openssl libressl

So, it shouldn't be having openssl as a dependency, yet when looking at the error log, it appears as if it thinks that is the case? I am confused.

@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor

So, it shouldn't be having openssl as a dependency, yet when looking at the error log, it appears as if it thinks that is the case? I am confused.

Blacklisting an outdated version of clang results in installing the latest available version, which depends on python311 for building. Python in turn depends on OpenSSL.
It might be worth trying to use the bootstrapped version to sort out this recursive mess, but I'd like a knowledgeable person's opinion.

@artkiver artkiver deleted the libressl-devel3.8.1_dos branch December 1, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants