Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faad2: update to 2.8.8 #2757

Merged
merged 1 commit into from
Oct 12, 2018
Merged

faad2: update to 2.8.8 #2757

merged 1 commit into from
Oct 12, 2018

Conversation

dgilman
Copy link
Contributor

@dgilman dgilman commented Oct 9, 2018

  • remove patch-automake-1.13.diff as it is now upstream

  • the above change made it unnecessary to autoreconf. Removed that too.

  • remove the --without-xmms --without-drm --without-mpeg4ip.
    These compile fine and don't break binary compatibility. I am not sure
    why they were removed: it was done in 7554f06 "faad2: update to 2.5"
    with no explanation why. The commit is dated Oct 6, 2006 and I suspect
    that the extra code was not working on Intel or Universal builds back
    in the wild days of the initial Intel transition.

    At any rate, the rest of the world (aka I looked at Debian and
    Homebrew) compile with these enabled so it can't be that bad.

  • Revbump all dependents of faad2 as the 2.7 -> 2.8 migration cleaned up
    many symbols accidentally exported by the dylib.

Type(s)
  • enhancement
Tested on

macOS 10.10.5 14F2511
Xcode 7.2 7C68

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@jeremyhu for port libquicktime-devel.
@ryandesign for port xine-lib.
@toots for port ocaml-faad.
@g5pw for port cmus.
@kencu for port scummvm.
@RJVB for port VLC.
@Ionic for port audacious-plugins.

@macportsbot
Copy link

Travis Build #3901 Errored.

Lint results 
--->  Verifying Portfile for JHymn
Warning: no license set
--->  0 errors and 1 warnings found.
--->  Verifying Portfile for aacgain
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for cmus
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for faad2
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for ices0
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for mpd
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for pianod
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for xmms2
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for scummvm
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for gstreamer010-gst-plugins-bad
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for gstreamer1-gst-plugins-bad
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for VLC
Error: Unknown PortGroup: compress_workdir-1.0
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for audacious-plugins
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for avidemux
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for gpac
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for gtkpod
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for libquicktime-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for libquicktime
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for xine-lib
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for ocaml-faad
--->  0 errors and 0 warnings found.

Port JHymn fail on xcode9.4. Log
Port aacgain success on xcode9.4. Log
Port JHymn fail on xcode8.3. Log
Port aacgain success on xcode8.3. Log
Port JHymn fail on xcode7.3. Log
Port aacgain success on xcode7.3. Log
Port JHymn fail on xcode10. Log
Port aacgain success on xcode10. Log

The build timed out.

ryandesign
ryandesign approved these changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@ryandesign ryandesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a minor nitpick about hardcoding the version in the master_sites, this looks great, thanks.

audio/faad2/Portfile Outdated
autoreconf.args -vif

configure.args --without-xmms --without-drm --without-mpeg4ip
master_sites sourceforge:project/faac/faad2-src/faad2-2.8.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hardcoding 2.8.0 here, I'd like to see this computed, e.g. using

set branch          [join [lrange [split ${version} .] 0 1] .]
master_sites        sourceforge:project/faac/faad2-src/faad2-${branch}.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgilman Can you fix this, squash, and force push?

@macportsbot
Copy link

Travis Build #3906 Errored.

Lint results 
--->  Verifying Portfile for JHymn
Warning: no license set
--->  0 errors and 1 warnings found.
--->  Verifying Portfile for aacgain
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for cmus
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for faad2
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for ices0
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for mpd
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for pianod
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for xmms2
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for scummvm
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for gstreamer010-gst-plugins-bad
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for gstreamer1-gst-plugins-bad
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for VLC
Error: Unknown PortGroup: compress_workdir-1.0
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for audacious-plugins
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for avidemux
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for gpac
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for gtkpod
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for libquicktime-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for libquicktime
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for xine-lib
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for ocaml-faad
--->  0 errors and 0 warnings found.

Port JHymn fail on xcode9.4. Log
Port aacgain success on xcode9.4. Log
Port JHymn fail on xcode8.3. Log
Port aacgain success on xcode8.3. Log
Port JHymn fail on xcode7.3. Log
Port aacgain success on xcode7.3. Log
Port JHymn fail on xcode10. Log
Port aacgain success on xcode10. Log

The build timed out.

@pmetzger
Copy link
Member

pmetzger commented Oct 9, 2018

Conflicts need resolving.

@dgilman
faad2: update to 2.8.8
9e79ca1 
* remove patch-automake-1.13.diff as it is now upstream
* the above change made it unnecessary to autoreconf. Removed that too.
* remove the --without-xmms --without-drm --without-mpeg4ip.
  These compile fine and don't break binary compatibility. I am not sure
  why they were removed: it was done in 7554f06 "faad2: update to 2.5"
  with no explanation why. The commit is dated Oct 6, 2006 and I suspect
  that the extra code was not working on Intel or Universal builds back
  in the wild days of the initial Intel transition.

  At any rate, the rest of the world (aka I looked at Debian and
  Homebrew) compile with these enabled so it can't be that bad.
* Revbump all dependents of faad2 as the 2.7 -> 2.8 migration cleaned up
  many symbols accidentally exported by the dylib.
@mf2k
Copy link
Contributor

mf2k commented Oct 9, 2018

Yes, JHymn just got axed. 😃

@macportsbot
Copy link

Travis Build #3916 Errored.

Lint results 
--->  Verifying Portfile for aacgain
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for cmus
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for faad2
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for ices0
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for mpd
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for pianod
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for xmms2
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for scummvm
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for gstreamer010-gst-plugins-bad
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for gstreamer1-gst-plugins-bad
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for VLC
Error: Unknown PortGroup: compress_workdir-1.0
--->  1 errors and 0 warnings found.
--->  Verifying Portfile for audacious-plugins
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for avidemux
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for gpac
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for gtkpod
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for libquicktime-devel
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for libquicktime
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for xine-lib
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for ocaml-faad
--->  0 errors and 0 warnings found.

Port aacgain success on xcode9.4. Log
Port aacgain success on xcode8.3. Log
Port aacgain success on xcode7.3. Log
Port aacgain success on xcode10. Log

The build timed out.

@pmetzger pmetzger merged commit b9e036d into macports:master Oct 12, 2018
@pmetzger
Copy link
Member

Merged. Thanks, @dgilman!

@dgilman dgilman deleted the faad2 branch November 20, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmetzger pmetzger pmetzger left review comments

@ryandesign ryandesign ryandesign approved these changes

Assignees

@ryandesign ryandesign

@g5pw g5pw

@Ionic Ionic

@jeremyhu jeremyhu

@kencu kencu

Labels
maintainer: requires approval type: enhancement type: update
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dgilman @macportsbot @pmetzger @mf2k @ryandesign @g5pw @Ionic @jeremyhu @kencu