exact-image: Use the right -arch flags and other flags #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to support building universal. See: https://trac.macports.org/ticket/57607
The configure script already does this.
macportsbot
added
by: member
|
Travis Build #4841 Failed. Lint resultsPort exact-image fail on xcode9.4. Log |
That's not what it did on my system. Hmm... |
|
Ah, I have the bash @4.4.23 port installed. Looks like some syntax I used doesn't work with macOS stock bash version 3. |
Use CPPFLAGS and CFLAGS/CXXFLAGS for most configure tests that involve the compiler. Use only CPPFLAGS when checking headers. Using CFLAGS/CXXFLAGS as well would cause a configure failure when using the universal variant. Closes: https://trac.macports.org/ticket/57607 Instead of checking $1 for an exact string match of "cc" or "c++", check only the first word of $1, because in some use cases $1 also contains some flags.
Needed to use the right -arch flags, which is needed to build universal. Because this also now causes MacPorts optimization flags and C++ stdlib flags to be used, increase the revision to rebuild. See: https://trac.macports.org/ticket/57607
ryandesign
force-pushed
the
exact-image-fixes
branch
from
88975c6
to
4aa25bc
Compare
|
Travis Build #4846 Passed. Lint resultsPort exact-image success on xcode9.4. Log |
|
Ok, this version of my modifications seems to work with bash 2, 3, or 4. |
|
@ryandesign Will you be merging this on your own? |
|
Yes, unless someone reviews it and finds something wrong with it. |
MarcusCalhoun-Lopez
approved these changes
Jan 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR began in an effort to fix the universal build failure I reported here. But there are so many things wrong in this build system that it took a larger effort to fix. I'm submitting it as a PR so that I can separate each logical change into its own commit, and to get a second opinion on whether I've done anything wrong. But it builds universal now for me, where it did not before. @MarcusCalhoun-Lopez, maybe you can take a look, since I'm changing a lot of stuff you added in the update to 1.0.1.
Type(s)
Tested on
macOS 10.13.6 17G65
Xcode 9.4.1 9F2000
Verification
Have you
port lint?sudo port test?sudo port -vst install?