ghc: Update to 8.6.5 and major Portfile refactoring #4794

essandess · 2019-07-10T09:05:59Z

Download x86_64-apple-darwin version from haskell.org
Include gpg signature verification
Bootstrap from source
Eliminate old patch files, compiler incompatibilities

Description

Type(s)

bugfix
enhancement
security fix

Tested on

macOS 10.x
Xcode 8.x

Verification

Have you

followed our Commit Message Guidelines?
squashed and minimized your commits?
checked that there aren't other open pull requests for the same change?
referenced existing tickets on Trac with full URL?

checked your Portfile with port lint?
tried existing tests with sudo port test?
tried a full install with sudo port -vst install?
tested basic functionality of all binary files?

macportsbot · 2019-07-10T09:06:02Z

Notifying maintainers:
@neverpanic for port ghc.

essandess · 2019-07-10T09:10:19Z

See also #4699. Some rebase issue created this new PR.

@neverpanic @pmetzger @mojca @ryandesign @cjones051073

cjones051073 · 2019-07-10T09:12:19Z

It was completely unnecessary to close the previous PR and open this one. This PR is using exactly the same branch....

macportsbot · 2019-07-10T10:53:09Z

Travis Build #7239 Errored.

Lint results

--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.

Port ghc's dependencies fail on xcode9.4. Log

The build timed out.

essandess · 2019-07-10T11:26:03Z

It was completely unnecessary to close the previous PR and open this one. This PR is using exactly the same branch....

You presume git intent…

mojca · 2019-07-10T11:39:04Z

Feel free to ask for help if you require some help with git magic next time when you end up in fight with the tools :)

cjones051073 · 2019-07-10T11:45:22Z

The point is as this PR is using the same feature branch as the old one, whatever was done to fix it would have worked just fine there. If we where to close this PR now and reopen the old one, the diffs/commits would be exactly as they are here. opening this second PR was just a waste of time...

essandess · 2019-07-10T12:02:49Z

Feel free to ask for help if you require some help with git magic next time when you end up in fight with the tools :)

#4699 (comment)

You all can do whatever git magic you want to clean this up the way you want.

In my experience the most efficient way of handling inscrutable git issues is not to chase hashes on a directed acyclic graph, but just delete and start over unless there would be some data loss issue.

cjones051073 · 2019-07-10T12:07:32Z

Feel free to ask for help if you require some help with git magic next time when you end up in fight with the tools :)

#4699 (comment)

You all can do whatever git magic you want to clean this up the way you want.

In my experience the most efficient way of handling inscrutable git issues is not to chase hashes on a directed acyclic graph, but just delete and start over unless there would be some data loss issue.

Thats fine. But still, a second PR is not required as you used the same branch name. Even if you deleted the branch locally, remade it from scratch and then (force) pushed it to github, the original PR would have reflected those changes. Please don't mix up rebuilding a branch with opening a new PR.

essandess · 2019-07-10T13:56:12Z

The build fail here is caused by not specifying a necessary dependency. I can easily add the python37 dependency, but I don’t know how to tell the Portfile build system to point python3 to python37. Just issue a port select --set command within system? Something else?

Error:

env: python3: No such file or directory

cjones051073 · 2019-07-10T14:06:20Z

The build fail here is caused by not specifying a necessary dependency. I can easily add the python37 dependency, but I don’t know how to tell the Portfile build system to point python3 to python37. Just issue a port select --set command within system? Something else?

Error:
env: python3: No such file or directory

You cannot use/rely on port select in a portfile. The canonical solution, if the upstream build system does not have an option to explicitly set the full path to the python executable, is to patch the build source to change the instances of 'python3' to directly refer to the required python version. see, for instance

macports-ports/science/root6/Portfile

Line 474 in bd3770d

# Fix python version in scripts

where I do something like this this for root6. A combination of a for loop, a find and a reinplace does the trick.

essandess · 2019-07-10T17:33:46Z

@cjones051073 Thanks! Fix added.

macportsbot · 2019-07-10T21:10:23Z

Travis Build #7248 Errored.

Lint results

--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.

Port ghc's dependencies fail on xcode8.3. Log

The build timed out.

essandess · 2019-07-12T13:59:38Z

@pmetzger ~~This is ready to commit, and is in the critical path of other pending submissions.~~

I figured out how to modify the build jobs and use thesysctl Function per previous discussion. This will build mod some minor issues. It’s ready when it builds.

macportsbot · 2019-07-15T18:08:59Z

Travis Build #7300 Errored.

Lint results

--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.

Port ghc's dependencies fail on xcode8.3. Log

The build timed out.

macportsbot · 2019-07-15T23:58:48Z

Travis Build #7312 Errored.

Lint results

--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.

The build timed out.

macportsbot · 2019-07-16T03:28:15Z

Travis Build #7314 Errored.

Lint results

--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.

The build timed out.

essandess · 2019-07-16T09:51:26Z

This is ready to commit.

lang/ghc/Portfile

mf2k · 2019-07-23T13:17:14Z

On the Mojave builder, the error appears to be:

Error: Failed to destroot ghc: can't read "configure.args": no such variable

mf2k · 2019-07-23T13:22:16Z

Looking at the output, in the destroot phase it has just executed the system command starting at line 154. But fails somewhere after that. Maybe it doesn't like configure commands/variables in the destroot phase?

essandess · 2019-07-23T13:35:13Z

@mf2k Thanks.

I believe I found the issue: parallel builds during the install phases. The make -j flag is being set implicitly and sometime explicitly in the bootstrap. Sometimes the stars line up and the workers don't conflict, sometimes they conflict and cause existing directory/file errors, as @mojca observed above.

I've been barking up a bunch of wrong trees because of this, assuming this is the fundamental cause. I refactored the Portfile and will try another push.

essandess · 2019-07-23T13:41:04Z

I'm trying to keep use_parallel_build yes for the stage 1 and 2 builds in this latest push, because I'm greedy. If that fails I'll roll back and just do exactly the build commands that the Makefile says should be done. That worked reliably before.

essandess · 2019-07-23T14:29:28Z

The penultimate push builds for me. In the latest push I've moved all bootstrapping phases into a post-build block to address a review comment from @neverpanic above. I believe that will get destrooted correctly from post-build…

macportsbot · 2019-07-23T15:51:36Z

Travis Build #7429 Errored.

Lint results

--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.

The build timed out.

macportsbot · 2019-07-23T17:36:55Z

Travis Build #7431 Errored.

Lint results

--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.

Port ghc's dependencies fail on xcode8.3. Log

The build timed out.

essandess · 2019-07-23T17:50:54Z

@mf2k @pmetzger @neverpanic @mojca @cjones051073

Thanks everyone for your help and comments.

This port is, finally, ready to commit.

mf2k · 2019-07-23T19:11:18Z

LGTM!

essandess · 2019-07-27T20:55:49Z

I added test support. I expect/hope this Portfile will also work.

macportsbot · 2019-07-27T23:25:39Z

Travis Build #7492 Errored.

Lint results

--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.

The build timed out.

macportsbot · 2019-07-28T01:56:14Z

Travis Build #7493 Errored.

Lint results

--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.

The build timed out.

* Download x86_64-apple-darwin version from haskell.org * Include gpg signature verification * Bootstrap from source * Eliminate old patch files, compiler incompatibilities

macportsbot · 2019-07-28T22:17:10Z

Travis Build #7506 Errored.

Lint results

--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.

Port ghc's dependencies fail on xcode9.4. Log
Port ghc's dependencies fail on xcode8.3. Log

The build timed out.

essandess · 2019-07-30T12:11:11Z

@mf2k @pmetzger @neverpanic @mojca @cjones051073

This Portfile is working great, and there’s no more tests or bells to add.

Would you all please take a look and merge if you agree? It’s in the critical path of a couple other PRs.

mf2k · 2019-07-30T15:05:18Z

I was hoping that the maintainer @neverpanic would do that.

essandess · 2019-08-07T11:39:23Z

@neverpanic @mf2k @pmetzger @mojca @cjones051073

This port update works. I’ve had the ghc binaries deployed for well over a month without issue. The previous version is years out of date.

May we please merge or identify any remaining issues?

essandess · 2019-08-17T22:24:17Z

@neverpanic @pmetzger @mojca @cjones051073

Ping. Would one of you please merge or call out any outstanding issues?

cjones051073 · 2019-08-18T18:21:22Z

Was hoping to hear from @neverpanic but its been long enough now.

amake · 2019-08-19T04:28:33Z

lang/ghc/Portfile


 name                ghc
-# Do not update GHC separate from Haskell Platform.
-# When updating GHC, make sure to revbump all Haskell ports.
-# Also make sure to update the version in the Haskell PortGroup.


These comments were deleted but it doesn't seem like required actions were documented anywhere else or were rendered unnecessary: I am currently unable to build something with the new ghc because all existing hs-* ports' binaries install for ghc 7.8.3.

What is the intended solution?

macportsbot assigned neverpanic Jul 10, 2019

macportsbot added maintainer: open Affects an openmaintainer port type: update labels Jul 10, 2019

essandess force-pushed the ghc branch from 4f7ee28 to 1c731fb Compare July 10, 2019 17:32

essandess force-pushed the ghc branch 2 times, most recently from dff3bb9 to e201a52 Compare July 10, 2019 17:58

mojca mentioned this pull request Jul 15, 2019

[WIP]: Add Hackage frontend support macports/upt-macports#39

Open

essandess force-pushed the ghc branch from e201a52 to d101162 Compare July 15, 2019 15:26

essandess force-pushed the ghc branch 2 times, most recently from 3afd6f1 to 22afb6b Compare July 15, 2019 22:11

essandess mentioned this pull request Jul 16, 2019

julia: Update to v1.1.1 with Portfile simplifications #4825

Merged

11 tasks

neverpanic reviewed Jul 16, 2019

View reviewed changes

essandess force-pushed the ghc branch from 651ca9d to 592480f Compare July 23, 2019 13:37

essandess force-pushed the ghc branch from 592480f to abdce08 Compare July 23, 2019 14:27

essandess force-pushed the ghc branch from abdce08 to a4de6ea Compare July 27, 2019 20:53

essandess force-pushed the ghc branch from a4de6ea to 2136118 Compare July 28, 2019 00:13

ghc: Update to 8.6.5 and major Portfile refactoring

c862681

* Download x86_64-apple-darwin version from haskell.org * Include gpg signature verification * Bootstrap from source * Eliminate old patch files, compiler incompatibilities

essandess force-pushed the ghc branch from 2136118 to c862681 Compare July 28, 2019 21:00

cjones051073 merged commit 2f22825 into macports:master Aug 18, 2019

essandess deleted the ghc branch August 18, 2019 18:29

amake reviewed Aug 19, 2019

View reviewed changes

amake mentioned this pull request Aug 19, 2019

[WIP] Fix broken Haskell world #5050

Closed

11 tasks

neverpanic mentioned this pull request Aug 19, 2019

WIP ShellCheck: update to 0.6.0 #4577

Closed

9 tasks

essandess mentioned this pull request Aug 25, 2019

gpg_verify-1.0.tcl: Submission of portgroup gpg_verify 1.0 #5124

Merged

12 tasks

ghc: Update to 8.6.5 and major Portfile refactoring #4794

ghc: Update to 8.6.5 and major Portfile refactoring #4794

Conversation

essandess commented Jul 10, 2019 • edited Loading

Description

Type(s)

Tested on

Verification

macportsbot commented Jul 10, 2019

essandess commented Jul 10, 2019

cjones051073 commented Jul 10, 2019

macportsbot commented Jul 10, 2019

essandess commented Jul 10, 2019

mojca commented Jul 10, 2019

cjones051073 commented Jul 10, 2019

essandess commented Jul 10, 2019

cjones051073 commented Jul 10, 2019

essandess commented Jul 10, 2019

cjones051073 commented Jul 10, 2019

essandess commented Jul 10, 2019

macportsbot commented Jul 10, 2019

essandess commented Jul 12, 2019 • edited Loading

macportsbot commented Jul 15, 2019

macportsbot commented Jul 15, 2019

macportsbot commented Jul 16, 2019

essandess commented Jul 16, 2019

mf2k commented Jul 23, 2019

mf2k commented Jul 23, 2019 • edited Loading

essandess commented Jul 23, 2019

essandess commented Jul 23, 2019

essandess commented Jul 23, 2019

macportsbot commented Jul 23, 2019

macportsbot commented Jul 23, 2019

essandess commented Jul 23, 2019

mf2k commented Jul 23, 2019

essandess commented Jul 27, 2019

macportsbot commented Jul 27, 2019

macportsbot commented Jul 28, 2019

macportsbot commented Jul 28, 2019

essandess commented Jul 30, 2019

mf2k commented Jul 30, 2019

essandess commented Aug 7, 2019

essandess commented Aug 17, 2019

cjones051073 commented Aug 18, 2019

amake Aug 19, 2019

Choose a reason for hiding this comment

essandess commented Jul 10, 2019 •

edited

Loading

essandess commented Jul 12, 2019 •

edited

Loading

mf2k commented Jul 23, 2019 •

edited

Loading