-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpg_verify-1.0.tcl: Submission of portgroup gpg_verify 1.0 #5124
Conversation
@essandess Many thanks for preparing the PG, much appreciated. It would though I think be useful if you include in this PR updates to a port or two (all if them if you want, up to you) showing how this new PG will be used to simplify what is currently there. |
e5ff917
to
fef5cb0
Compare
I committed mods for the ports of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good idea. I had asked about having this functionality some time within the past couple of years (I think on IRC), but can't find where. Indeed I was told the working assumption is that portfile authors would be the ones to verify any signatures, and not make MacPorts dependent on GPG (which macOS does not include) to do this step.
Travis Build #7914 Errored. Lint results
The build timed out. |
Looking forward to this, too :) A minor bit: how about changing the name "keyid_file" to "pubkey_file"? Those files contain public keys instead key IDs, so the latter is clearer IMO. |
fef5cb0
to
b4b0109
Compare
@yan12125 Thanks. Done. |
Travis Build #7944 Errored. Lint results
Port ghc's dependencies fail on xcode10.3. Log The build timed out. |
64c7144
to
601ee25
Compare
Travis Build #8024 Errored. Lint results
Port ghc's dependencies fail on xcode7.3. Log The build timed out. |
Travis Build #8027 Errored. Lint results
Port ghc's dependencies fail on xcode7.3. Log The build timed out. |
601ee25
to
02c3f21
Compare
Travis Build #8032 Errored. Lint results
The build timed out. |
02c3f21
to
db01597
Compare
Travis Build #8053 Errored. Lint results
The build timed out. |
So where do we now stand with this ? Is it ready to go now ? |
Yes on my end. |
db01597
to
b7fece4
Compare
Travis Build #8195 Errored. Lint results
The build timed out. |
@cjones051073 Ping. Ready to merge. |
gpg_verify-1.0.tcl: Submission of portgroup gpg_verify 1.0
Description
See:
Type(s)
Tested on
macOS 10.x
Xcode 8.x
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
?