Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpg_verify-1.0.tcl: Submission of portgroup gpg_verify 1.0 #5124

Merged
merged 1 commit into from
Sep 14, 2019

Conversation

essandess
Copy link
Contributor

gpg_verify-1.0.tcl: Submission of portgroup gpg_verify 1.0

Description

See:

Type(s)
  • submission
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.x
Xcode 8.x

Verification

Have you

  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@cjones051073
Copy link
Member

@essandess Many thanks for preparing the PG, much appreciated.

It would though I think be useful if you include in this PR updates to a port or two (all if them if you want, up to you) showing how this new PG will be used to simplify what is currently there.

@essandess
Copy link
Contributor Author

@cjones051073

It would though I think be useful if you include in this PR updates to a port or two (all if them if you want, up to you) showing how this new PG will be used to simplify what is currently there.

I committed mods for the ports of ghc and Julia.

Copy link
Contributor

@chrstphrchvz chrstphrchvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good idea. I had asked about having this functionality some time within the past couple of years (I think on IRC), but can't find where. Indeed I was told the working assumption is that portfile authors would be the ones to verify any signatures, and not make MacPorts dependent on GPG (which macOS does not include) to do this step.

_resources/port1.0/group/gpg_verify-1.0.tcl Outdated Show resolved Hide resolved
_resources/port1.0/group/gpg_verify-1.0.tcl Show resolved Hide resolved
_resources/port1.0/group/gpg_verify-1.0.tcl Outdated Show resolved Hide resolved
@macportsbot
Copy link

Travis Build #7914 Errored.

Lint results
--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for julia
--->  0 errors and 0 warnings found.

The build timed out.

@yan12125
Copy link
Contributor

Looking forward to this, too :)

A minor bit: how about changing the name "keyid_file" to "pubkey_file"? Those files contain public keys instead key IDs, so the latter is clearer IMO.

@essandess
Copy link
Contributor Author

@yan12125 Thanks. Done.

@macportsbot
Copy link

Travis Build #7944 Errored.

Lint results
--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for julia
--->  0 errors and 0 warnings found.

Port ghc's dependencies fail on xcode10.3. Log
Port julia success on xcode10.3. Log
Port ghc's dependencies fail on xcode8.3. Log
Port julia success on xcode8.3. Log

The build timed out.

@essandess essandess force-pushed the portgroup-gpg_verify branch 3 times, most recently from 64c7144 to 601ee25 Compare September 2, 2019 13:08
@macportsbot
Copy link

Travis Build #8024 Errored.

Lint results
--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for julia
--->  0 errors and 0 warnings found.

Port ghc's dependencies fail on xcode7.3. Log
Port julia fail on xcode7.3. Log
Port stack fail on xcode7.3. Log

The build timed out.

@macportsbot
Copy link

Travis Build #8027 Errored.

Lint results
--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for julia
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for stack
--->  0 errors and 0 warnings found.

Port ghc's dependencies fail on xcode7.3. Log
Port julia fail on xcode7.3. Log
Port stack fail on xcode7.3. Log

The build timed out.

@macportsbot
Copy link

Travis Build #8032 Errored.

Lint results
--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for julia
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for stack
--->  0 errors and 0 warnings found.

The build timed out.

@macportsbot
Copy link

Travis Build #8053 Errored.

Lint results
--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for julia
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for stack
--->  0 errors and 0 warnings found.

The build timed out.

@cjones051073
Copy link
Member

So where do we now stand with this ? Is it ready to go now ?

@essandess
Copy link
Contributor Author

@cjones051073

So where do we now stand with this ? Is it ready to go now ?

Yes on my end.

@macportsbot
Copy link

Travis Build #8195 Errored.

Lint results
--->  Verifying Portfile for ghc
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for julia
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for stack
--->  0 errors and 0 warnings found.

The build timed out.

@essandess
Copy link
Contributor Author

@cjones051073 Ping. Ready to merge.

@cjones051073 cjones051073 merged commit 7efb802 into macports:master Sep 14, 2019
@essandess essandess deleted the portgroup-gpg_verify branch September 14, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants