Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ld64: add tapi support to ld64-latest #6223

Closed
wants to merge 3 commits into from
Closed

ld64: add tapi support to ld64-latest #6223

wants to merge 3 commits into from

Conversation

kencu
Copy link
Contributor

@kencu kencu commented Jan 23, 2020

this PR spins off the previous ld64-latest as ld64-274, which is the last version that will build without tapi support.

the ld64-latest port adds in tapi support using libtapi, but for the moment, at the same version as before (274).

this should allow ld64-latest to be updated now -- the latest version on the Apple open source website is 450.3, I notice, at this time.

@kencu kencu added the wip Work in progress label Jan 23, 2020
@macportsbot
Copy link

Notifying maintainers:
@jeremyhu for port ld64.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer labels Jan 23, 2020
@kencu
Copy link
Contributor Author

kencu commented Jan 23, 2020

ld64-latest (with tapi) builds and works on 10.13 against the MacOSX10.14.sdk, however, it does not function on 10.14, indicating a link error that looks unrelated to TAPI ; I think 274 is just too old for Mojave, so it would make sense to update ld64 to something more current before proceeding.

@kencu
Copy link
Contributor Author

kencu commented Jan 23, 2020

409.12 builds as well, with only a minor modification to the Makefile, but it requires another patch to libtapi for the newer functionality in ld64-409.12. It looks like this patch tpoechtrager/apple-libtapi@90d0bae might implement all the enhancements needed (to be further clarified), and would replace iain's libtapi zippered patch.

With tpoechtrager's patch for zippered support, ld64 @409.12 builds on 10.13 without issues.

spin off ld64-274 into its own port
build of ld64-latest completes successfully
on 10.13 with ld64 274.2
correlates with Xcode 9.4.1
builds successfully on 10.13

outline issues with 409.12 and 450.3 at present
note other builds of ld64  need to be reconfirmed against new dyld
@macportsbot
Copy link

Travis Build #10107 Failed.

Lint results
--->  Verifying Portfile for ld64
Warning: dyld-655.1.1.tar.gz - missing recommended checksum type: size
Warning: ld64-97-standalone-libunwind-headers.patch - missing recommended checksum type: size
Warning: ld64-97.17.tar.gz - missing recommended checksum type: size
Warning: ld64-127.2.tar.gz - missing recommended checksum type: size
Warning: ld64-236.3.tar.gz - missing recommended checksum type: size
Warning: ld64-274.2.tar.gz - missing recommended checksum type: size
--->  0 errors and 6 warnings found.

Port ld64-xcode success on xcode10.3. Log
Port ld64 success on xcode10.3. Log
Port ld64-97 fail on xcode10.3. Log
Port ld64-127 fail on xcode10.3. Log
Port ld64-236 fail on xcode10.3. Log
Port ld64-274 fail on xcode10.3. Log
Port ld64-latest fail on xcode10.3. Log
Port ld64-xcode success on xcode9.4. Log
Port ld64 success on xcode9.4. Log
Port ld64-97 fail on xcode9.4. Log
Port ld64-127 fail on xcode9.4. Log
Port ld64-236 success on xcode9.4. Log
Port ld64-274 success on xcode9.4. Log
Port ld64-latest success on xcode9.4. Log
Port ld64-latest fail on xcode8.3. Log
Port ld64's dependencies fail on xcode8.3. Log
Port ld64-97 fail on xcode8.3. Log
Port ld64-127 fail on xcode8.3. Log
Port ld64-236 fail on xcode8.3. Log
Port ld64-274 fail on xcode8.3. Log
Port ld64-xcode success on xcode8.3. Log
Port ld64-latest fail on xcode7.3. Log
Port ld64 fail on xcode7.3. Log
Port ld64-97 fail on xcode7.3. Log
Port ld64-127 fail on xcode7.3. Log
Port ld64-236 fail on xcode7.3. Log
Port ld64-274 fail on xcode7.3. Log

@macports macports deleted a comment from macportsbot Jan 24, 2020
@macports macports deleted a comment from macportsbot Jan 24, 2020
@macports macports deleted a comment from macportsbot Jan 24, 2020
@macports macports deleted a comment from macportsbot Jan 24, 2020
@kencu
Copy link
Contributor Author

kencu commented Jan 24, 2020

this has become a bit more complicated, now that just adding tapi to ld64-274 is not the only process here, and we're adding an upgrade to ld64-latest as well. I will reopen when this is ready for Jeremy (and any interested others) to review.

@kencu kencu closed this Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer wip Work in progress
Development

Successfully merging this pull request may close these issues.

3 participants