Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang-1.0: handle dependencies from salsa.debian.org #8759

Merged
merged 2 commits into from
Oct 13, 2020
Merged

golang-1.0: handle dependencies from salsa.debian.org #8759

merged 2 commits into from
Oct 13, 2020

Conversation

jasperweiss
Copy link
Contributor

Description

Whilst making a Portfile for wormhole-william I ran into this issue:

Error: go.vendors can't handle dependencies from salsa.debian.org

This should fix that. salsa.debian.org is a gitlab instance so the url structure should be the same.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

salsa.debian.org is just a gitlab instance so the url structure should be the same
@jasperweiss jasperweiss changed the title Handle dependencies from salsa.debian.org golang-1.0: Handle dependencies from salsa.debian.org Oct 12, 2020
@jasperweiss jasperweiss changed the title golang-1.0: Handle dependencies from salsa.debian.org golang-1.0: handle dependencies from salsa.debian.org Oct 12, 2020
@raimue raimue requested a review from amake October 12, 2020 17:13
Co-authored-by: Clemens Lang <cl@clang.name>
Copy link
Contributor

@amake amake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied @neverpanic's suggestion and now LGTM

@macportsbot
Copy link

Travis Build #14587 Passed.

@neverpanic neverpanic merged commit 446922b into macports:master Oct 13, 2020
neverpanic added a commit that referenced this pull request Oct 13, 2020
We're handling gitlab.com and salsa.debian.org in a single block now, so
remove the duplicate block for gitlab.com.

I forgot to fix this correctly before merging the pull request.

See: #8759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants