Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admins getter #345

Merged
merged 11 commits into from
Oct 29, 2018
Merged

Admins getter #345

merged 11 commits into from
Oct 29, 2018

Conversation

GasparPizarro
Copy link
Contributor

The REGISTRATION_ADMINS can be a list of (name, email) pairs as always, or can be the import path of a callable that returns a list like that.

@GasparPizarro GasparPizarro mentioned this pull request Oct 28, 2018
Closed
@ZeroCoolHacker
Copy link

Nice work

@GasparPizarro GasparPizarro reopened this Oct 28, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 97.152% when pulling 71c7cc6 on GasparPizarro:admins-getter into 7c9cadb on macropin:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 97.152% when pulling 71c7cc6 on GasparPizarro:admins-getter into 7c9cadb on macropin:master.

joshblum
joshblum approved these changes Oct 29, 2018
View reviewed changes
Copy link
Collaborator

@joshblum joshblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@joshblum joshblum merged commit 57d0f02 into macropin:master Oct 29, 2018
@GasparPizarro GasparPizarro deleted the admins-getter branch January 2, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblum joshblum joshblum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GasparPizarro @ZeroCoolHacker @coveralls @joshblum