Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added cids to constructor of Signals Returns #1200

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

sandresen1
Copy link
Contributor

No description provided.

@sandresen1 sandresen1 requested review from rsueppel and a team as code owners November 6, 2023 18:59
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1200 (256569c) into develop (f709ff2) will decrease coverage by 0.93%.
Report is 25 commits behind head on develop.
The diff coverage is 22.75%.

❗ Current head 256569c differs from pull request most recent head 14d6bb7. Consider uploading reports for the commit 14d6bb7 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1200      +/-   ##
===========================================
- Coverage    78.41%   77.48%   -0.93%     
===========================================
  Files           61       62       +1     
  Lines         5146     5255     +109     
===========================================
+ Hits          4035     4072      +37     
- Misses        1111     1183      +72     
Files Coverage Δ
macrosynergy/learning/__init__.py 100.00% <100.00%> (ø)
macrosynergy/signal/signal_base.py 99.34% <100.00%> (+<0.01%) ⬆️
macrosynergy/signal/signal_return.py 99.43% <66.66%> (-0.57%) ⬇️
macrosynergy/learning/preds_to_pnl.py 17.77% <17.77%> (ø)
macrosynergy/learning/transformers.py 21.27% <21.27%> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

Magnus167
Magnus167 previously approved these changes Nov 7, 2023
@sandresen1 sandresen1 merged commit 52f4d3b into develop Nov 7, 2023
4 checks passed
@sandresen1 sandresen1 deleted the feature/cids_signal_returns branch November 7, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants