Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add warning to when cids specified in Signal Base are not in the reduced dataframe #1201

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

sandresen1
Copy link
Contributor

@sandresen1 sandresen1 commented Nov 6, 2023

MERGE-AFTER-#1200

@sandresen1 sandresen1 requested review from rsueppel and a team as code owners November 6, 2023 19:06
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1201 (3a24f87) into develop (256569c) will decrease coverage by 0.03%.
Report is 1 commits behind head on develop.
The diff coverage is 66.66%.

❗ Current head 3a24f87 differs from pull request most recent head 042095b. Consider uploading reports for the commit 042095b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1201      +/-   ##
===========================================
- Coverage    77.48%   77.46%   -0.03%     
===========================================
  Files           62       62              
  Lines         5255     5259       +4     
===========================================
+ Hits          4072     4074       +2     
- Misses        1183     1185       +2     
Files Coverage Δ
macrosynergy/signal/signal_base.py 98.07% <66.66%> (-1.27%) ⬇️

Impacted file tree graph

@sandresen1 sandresen1 merged commit ff16330 into develop Nov 7, 2023
4 checks passed
@sandresen1 sandresen1 deleted the feature/addwarning_signal_return branch November 7, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants