Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Warning added to _prepare_basket #803

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

Magnus167
Copy link
Member

The function has a print statement. This implies the function can have behavior that can't be easily tested, or passed on to functions that may use it.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (d71ef87) 75.48% compared to head (e5a9507) 75.51%.

❗ Current head e5a9507 differs from pull request most recent head 5057a4a. Consider uploading reports for the commit 5057a4a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #803      +/-   ##
===========================================
+ Coverage    75.48%   75.51%   +0.03%     
===========================================
  Files           31       31              
  Lines         3667     3672       +5     
===========================================
+ Hits          2768     2773       +5     
  Misses         899      899              
Impacted Files Coverage Δ
macrosynergy/panel/make_relative_value.py 98.80% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Magnus167 Magnus167 requested a review from rsueppel May 31, 2023 08:57
@rsueppel rsueppel merged commit 5fa7280 into develop Jun 16, 2023
6 checks passed
@Magnus167 Magnus167 deleted the bugfix/test_relative_value_print branch June 30, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants