Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Added warning behavior to CategoryRelations.intersection_cids #804

Merged
merged 1 commit into from
May 18, 2023

Conversation

Magnus167
Copy link
Member

The function has a print statement. This implies the function can have behavior that can't be easily tested, or passed on to functions that may use it. (related - #803)

@Magnus167 Magnus167 requested a review from rsueppel May 15, 2023 19:53
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (d71ef87) 75.48% compared to head (c1e6c55) 75.50%.

❗ Current head c1e6c55 differs from pull request most recent head ed0a676. Consider uploading reports for the commit ed0a676 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #804      +/-   ##
===========================================
+ Coverage    75.48%   75.50%   +0.02%     
===========================================
  Files           31       31              
  Lines         3667     3670       +3     
===========================================
+ Hits          2768     2771       +3     
  Misses         899      899              
Impacted Files Coverage Δ
macrosynergy/panel/category_relations.py 40.23% <100.00%> (+0.70%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rsueppel rsueppel merged commit d8c8351 into develop May 18, 2023
6 checks passed
@Magnus167 Magnus167 deleted the bugfix/intersection_cids_warning branch May 23, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants