accept multi-byte comment when run code #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogimogitomato
changed the title
mogimogitomato
changed the title
mactkg
reviewed
Nov 19, 2019
src/extension.ts
Outdated
| @@ -53,7 +54,8 @@ class SonicPi { | |||
| if(!editor) { | |||
| return; | |||
| } | |||
| return editor.document.getText(); | |||
| const iconv = require('iconv-lite'); | |||
There was a problem hiding this comment.
I think that we can import iconv-lite at top of this file. Do you have any reason to require the library here?
There was a problem hiding this comment.
Sorry, I should modify getCurrentCode() type definition String to Buffer.
but I tried to tsc without modify, called require, not import.
It's wrong, so I fixed mistakes.
src/type.d.ts
Outdated
| @@ -0,0 +1,2 @@ | |||
| declare module 'osc-js'; | |||
| declare module 'iconv-lite'; | |||
There was a problem hiding this comment.
I found index.d.ts file for iconv-lite: https://github.com/ashtuchkin/iconv-lite/blob/17d00ab8cd663acafe390d8224ca1d44cb0b2085/lib/index.d.ts
Should we declare iconv-lite?
There was a problem hiding this comment.
You're right, there're no need to declare iconv-lite.
I restore modification.
mod method's return type restore declaration change mod iconv's require to import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add utf-8 encoding when sending code to sonic-pi.