Use Python 3 stable ABI to build MacVim, and better Python discovery #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vim added support for using Python 3 stable ABI in 9.0.1776, which allows us to safely load Python libraries of a different version from what Vim was built against. Modify our CI to use that. This allows user to use whatever Python version they want as long as it's above the minimum target. Given that macOS/Xcode still ships with 3.9 by default, we build using 3.9 as the minimum version. Also, change our Python detection script to work better. Change all explicit versions in our paths to refer to the "Current" version instead which for the most part should "just work" instead of requiring an exact match every time we or Python update to a new version (e.g. Homebrew will update the Current version to point to the latest Python3). Also add support for finding Python 3 from Xcode Command Line Tools which was previously not ok to use technically because it's 3.9 and before stable ABI support we couldn't load it safely as MacVim was built using newer versions. Fix macvim-dev#1351.
ychin
added a commit
that referenced
this pull request
Sep 12, 2023
Updated to Vim 9.0.1897 Special Notes ==================== As some of you may have read, Bram Moolenaar, the creator of Vim, has [passed away](https://groups.google.com/g/vim_announce/c/tWahca9zkt4) recently. He has worked tirelessly on Vim for more than 30 years and this release is dedicated to him. If you would like, you could pay your respects at [this discussion thread](vim/vim#12737). The Vim project has transitioned to new maintainers, and MacVim will continue to be supported as long as Vim is around. Features ==================== More flexible Python integration -------------------- MacVim now allows you to use Python runtime (via `pythonthreedll`, used for Python plugins) of any version at or above 3.9. Previously you had to use the exact same version that was used to build MacVim (Python 3.11). The Python detection logic is also updated to always just find the latest version of Homebrew Python instead of a fixed one, and it will also now locate the default macOS / Xcode Python provided by the Xcode Command Line Tools if that is the only Python available. This should hopefully make configuring Python for MacVim a lot more seamless. See `:h python3-stable-abi`. Vim v9.0.1776 / #1428. New Vim features -------------------- - New built-in support for [EditorConfig](https://editorconfig.org/) via an optional package. Use `packadd editorconfig` to activate it. See vim/vim#12902. - `g<End>` now goes to the first non-blank char. v9.0.1753 - API changes - `undotree()` now takes a bufnr v9.0.1686 - `printf()` now takes positional arguments v9.0.1704 - `virtcol()` now takes winid v9.0.1728 - quickfix items can now have user data v9.0.1688 - Miscellaneous security fixes. Security Fixes ==================== - Fixed insecure usages of interprocess communication in MacVim (CVE-2023-41036) Fixes ==================== - Fixed MacVim to correctly set up the runtime folder in the app bundle. As a corollary, `xxd` is now bundled with MacVim like most other Vim distributions, and MacVim.app now provides man page for the CLI vim commands if the user wants to associate man pages with the `mvim` comamnd (see `:h macvim-PATH`). #1430 - Fixed Vim occasionally crashing and/or hung when autocmd calls `serverlist()` on exit. #1427 Scripting ==================== - Scripting languages versions: - Python now supports 3.9 or above. Compatibility ==================== Requires macOS 10.9 or above. (10.9 - 10.12 requires downloading a separate legacy build) Script interfaces have compatibility with these versions: - Lua 5.4 - Perl 5.30 - Python2 2.7 - Python3 3.9 or above - Ruby 3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vim added support for using Python 3 stable ABI in 9.0.1776, which allows us to safely load Python libraries of a different version from what Vim was built against. Modify our CI to use that. This allows user to use whatever Python version they want as long as it's above the minimum target. Given that macOS/Xcode still ships with 3.9 by default, we build using 3.9 as the minimum version.
Also, change our Python detection script to work better. Change all explicit versions in our paths to refer to the "Current" version instead which for the most part should "just work" instead of requiring an exact match every time we or Python update to a new version (e.g. Homebrew will update the Current version to point to the latest Python3). Also add support for finding Python 3 from Xcode Command Line Tools which was previously not ok to use technically because it's 3.9 and before stable ABI support we couldn't load it safely as MacVim was built using newer versions.
Fix #1351.