Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Distribute the editorconfig with vim #12902

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

chrisbra
Copy link
Member

This is the editorconfig-vim plugin Commit e014708e917b457e8f6c57f357d55dd3826880d4 from https://github.com/editorconfig/editorconfig-vim

closes: #2286
related: editorconfig/editorconfig-vim#223

Signed-off-by: Christian Brabandt cb@256bit.org

This is the editorconfig-vim plugin Commit e014708e917b457e8f6c57f357d55dd3826880d4
from https://github.com/editorconfig/editorconfig-vim

closes: vim#2286
related: editorconfig/editorconfig-vim#223

Signed-off-by: Christian Brabandt <cb@256bit.org>
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #12902 (7e8f687) into master (2f25e40) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #12902   +/-   ##
=======================================
  Coverage   82.04%   82.04%           
=======================================
  Files         160      160           
  Lines      194679   194679           
  Branches    43696    43696           
=======================================
+ Hits       159719   159724    +5     
+ Misses      22098    22092    -6     
- Partials    12862    12863    +1     
Flag Coverage Δ
huge-clang-none 82.65% <ø> (-0.01%) ⬇️
linux 82.65% <ø> (-0.01%) ⬇️
mingw-x64-HUGE 76.59% <ø> (+<0.01%) ⬆️
mingw-x86-HUGE 77.09% <ø> (+0.01%) ⬆️
windows 78.19% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

@chrisbra chrisbra merged commit e5e0430 into vim:master Aug 27, 2023
32 of 33 checks passed
@chdiza
Copy link

chdiza commented Aug 29, 2023

I don't think it's appropriate for this commit to include a plugin-specific test-suite and a bunch of plugin-specific git detritus.

There is no reason why a bundled plugin should have to be identical to the project's upstream git repo, is there? People who want to continually update it can do it in their ~/.vim using the pack infrastructure that was made specifically to make this easier.

chrisbra added a commit that referenced this pull request Aug 29, 2023
Remove the test suite and a few other non-used files from the
EditorConfig CI project

related: #12902
closes:  #12941

Signed-off-by: Christian Brabandt <cb@256bit.org>
@chrisbra
Copy link
Member Author

I removed those. Let me know if this is fine.

@chdiza
Copy link

chdiza commented Aug 29, 2023

Looks good, but I'd also remove mkzip.sh. Thanks!

Konfekt pushed a commit to Konfekt/vim that referenced this pull request Aug 30, 2023
This is the editorconfig-vim plugin Commit e014708e917b457e8f6c57f357d55dd3826880d4
from https://github.com/editorconfig/editorconfig-vim

closes: vim#2286
related: editorconfig/editorconfig-vim#223

Signed-off-by: Christian Brabandt <cb@256bit.org>
Konfekt pushed a commit to Konfekt/vim that referenced this pull request Aug 30, 2023
Remove the test suite and a few other non-used files from the
EditorConfig CI project

related: vim#12902
closes:  vim#12941

Signed-off-by: Christian Brabandt <cb@256bit.org>
ychin added a commit to macvim-dev/macvim that referenced this pull request Sep 12, 2023
Updated to Vim 9.0.1897

Special Notes
====================

As some of you may have read, Bram Moolenaar, the creator of Vim, has
[passed away](https://groups.google.com/g/vim_announce/c/tWahca9zkt4)
recently. He has worked tirelessly on Vim for more than 30 years and
this release is dedicated to him. If you would like, you could pay your
respects at [this discussion
thread](vim/vim#12737).

The Vim project has transitioned to new maintainers, and MacVim will continue
to be supported as long as Vim is around.

Features
====================

More flexible Python integration
--------------------

MacVim now allows you to use Python runtime (via `pythonthreedll`, used
for Python plugins) of any version at or above 3.9. Previously you had
to use the exact same version that was used to build MacVim (Python
3.11). The Python detection logic is also updated to always just find
the latest version of Homebrew Python instead of a fixed one, and it
will also now locate the default macOS / Xcode Python provided by the
Xcode Command Line Tools if that is the only Python available. This
should hopefully make configuring Python for MacVim a lot more seamless.
See `:h python3-stable-abi`. Vim v9.0.1776 / #1428.

New Vim features
--------------------

- New built-in support for [EditorConfig](https://editorconfig.org/) via
  an optional package. Use `packadd editorconfig` to activate it. See
  vim/vim#12902.
- `g<End>` now goes to the first non-blank char. v9.0.1753
- API changes
  - `undotree()` now takes a bufnr v9.0.1686
  - `printf()` now takes positional arguments v9.0.1704
  - `virtcol()` now takes winid v9.0.1728
  - quickfix items can now have user data v9.0.1688
- Miscellaneous security fixes.

Security Fixes
====================

- Fixed insecure usages of interprocess communication in MacVim
(CVE-2023-41036)

Fixes
====================

- Fixed MacVim to correctly set up the runtime folder in the app bundle.
  As a corollary, `xxd` is now bundled with MacVim like most other Vim
  distributions, and MacVim.app now provides man page for the CLI vim
  commands if the user wants to associate man pages with the `mvim`
  comamnd (see `:h macvim-PATH`). #1430
- Fixed Vim occasionally crashing and/or hung when autocmd calls
  `serverlist()` on exit. #1427

Scripting
====================

- Scripting languages versions:
    - Python now supports 3.9 or above.

Compatibility
====================

Requires macOS 10.9 or above. (10.9 - 10.12 requires downloading a
separate legacy build)

Script interfaces have compatibility with these versions:

- Lua 5.4
- Perl 5.30
- Python2 2.7
- Python3 3.9 or above
- Ruby 3.2
chrisbra added a commit to chrisbra/vim that referenced this pull request Sep 22, 2023
This is the editorconfig-vim plugin Commit e014708e917b457e8f6c57f357d55dd3826880d4
from https://github.com/editorconfig/editorconfig-vim

closes: vim#2286
related: editorconfig/editorconfig-vim#223

Signed-off-by: Christian Brabandt <cb@256bit.org>
chrisbra added a commit to chrisbra/vim that referenced this pull request Sep 22, 2023
Remove the test suite and a few other non-used files from the
EditorConfig CI project

related: vim#12902
closes:  vim#12941

Signed-off-by: Christian Brabandt <cb@256bit.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: ship with EditorConfig plugin by default
2 participants