Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it compatible for Magento CE 1.7 / Magento EE 1.12 #57

Closed
madalinoprea opened this issue Feb 17, 2016 · 3 comments
Closed

Make it compatible for Magento CE 1.7 / Magento EE 1.12 #57

madalinoprea opened this issue Feb 17, 2016 · 3 comments
Assignees
@madalinoprea
Labels
Low
Milestone
1.5.1

Comments

@madalinoprea
Copy link
Owner

Currently we don't plan to spent any time on this issue. Please let us know if you're on any of these Magento version and we'll take a look.

For now we know at least one error that needs to be addressed for Magento CE 1.7:
.PHP Fatal error: Call to undefined method Mock_Magento_Db_Adapter_Pdo_Mysql_3fc14b29::delete() in /home/travis/build/madalinoprea/magneto-debug/code/Debug/Model/Service.php on line 215

@lfolco
Copy link

lfolco commented Mar 2, 2016

I'm using 1.7 and would like to see it fixed.

madalinoprea added a commit that referenced this issue Mar 3, 2016
@madalinoprea
Adds block method _getApp to support Magento CE 1.7 #57
e2500be
madalinoprea added a commit that referenced this issue Mar 3, 2016
@madalinoprea
re-enable unit tests for Magento CE 1.7 #57
15d6043
madalinoprea added a commit that referenced this issue Mar 3, 2016
@madalinoprea
Mock parent class instead of Magento_Db_Adapter_Pdo_Mysql which is wa…
854b0a6 
…s added after Magento CE 1.7 #57
madalinoprea added a commit that referenced this issue Mar 3, 2016
@madalinoprea
Mock parent class instead of Magento_Db_Adapter_Pdo_Mysql which was a…
33ed07a 
…dded after Magento CE 1.7 #57
@madalinoprea
Copy link
Owner Author

Hi @lfolco ,

I've added compatibility for Magento CE 1.7 (I assume is ok for Magento EE 1.12 but I didn't test it). These code is going to be released tomorrow as part of version 1.5.1

screen shot 2016-03-03 at 21 50 52

@madalinoprea madalinoprea added this to the 1.5.1 milestone Mar 3, 2016
@madalinoprea madalinoprea self-assigned this Mar 3, 2016
madalinoprea added a commit that referenced this issue Mar 3, 2016
@madalinoprea
Update readme to mention support for Magento CE 1.7 #57
44c9b0d
@lfolco
Copy link

lfolco commented Mar 3, 2016

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madalinoprea madalinoprea

Labels
Low
Projects
None yet
Milestone
1.5.1
Development

No branches or pull requests
2 participants
@madalinoprea @lfolco