Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fix checks if magento is installed before running sheep debug. #100

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

Tickles-BV
Copy link
Contributor

We install sheep-debug as part of our base install, which is all run through composer.

We're running into an issue where if you deploy a new project and try to access it before magento has been installed you get a 500 error instead of the web installer.

This is because replaceProfiler fetches the core_write connection and tries to replace the profiler without checking if magento is installed. This fix adds an extra check in isEnabled in the Data helper to ensure core_write is available.

@coveralls
Copy link

coveralls commented Oct 12, 2017

Coverage Status

Coverage decreased (-0.1%) to 91.53% when pulling b9093a0 on Tickles-BV:fix-database-handling into 547ef47 on madalinoprea:master.

@madalinoprea madalinoprea merged commit 9566e83 into madalinoprea:master Oct 12, 2017
@madalinoprea
Copy link
Owner

Thanks for your contribution 👍

@Tickles-BV Tickles-BV deleted the fix-database-handling branch October 13, 2017 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants