Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix redirects always going to the default store main URL #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

psdevhh
Copy link

@psdevhh psdevhh commented May 10, 2016

I'm running a multi store setup and have noticed, that whenever I use one of the magneto-debug utilities (like "Enable/disable template hints" etc.), I get redirected to the default store main URL, instead of the page in the store I'm currently on.

I haven't yet investigated, why _redirectReferer always redirects to the default store URL, but the changes in this commit fix that behaviour and make the redirects work as expected.

@coveralls
Copy link

coveralls commented May 10, 2016

Coverage Status

Changes Unknown when pulling cd63652 on pschnell:master into * on madalinoprea:master*.

@madalinoprea
Copy link
Owner

Hi @PSchnell,

I'm not sure if your changeset is correct. My assumptions is that current implementation is doing the same thing. _redirectReferer is identifying referring url based on HTTP_REFERER, if found is going to set it on response like you're doing.

The only difference in your commit is that you're also sending response. Maybe this line is fixing your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants