Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for commands.go file #54

Open
anatoliyfedorenko opened this issue Jul 18, 2019 · 2 comments
Open

Add tests for commands.go file #54

anatoliyfedorenko opened this issue Jul 18, 2019 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@anatoliyfedorenko
Copy link
Contributor

anatoliyfedorenko commented Jul 18, 2019 •
edited
Loading

all the functions in commands.go file are not tested, need to add tests for each of them and cover all test cases
anatoliyfedorenko added a commit that referenced this issue Jul 18, 2019
@anatoliyfedorenko
Fix #52 add more tests to commands.go file #54
21855f5
@anatoliyfedorenko
Copy link
Contributor Author

Only ChangeUserTimeZone ChangeGroupTimeZone ChangeAdvisesStatus functions are left to test

sula7 pushed a commit that referenced this issue Jul 18, 2019
#54 Added test for func TestChangeGroupTimeZone in commands_test.go
972f227
@sula7 sula7 mentioned this issue Jul 18, 2019
Merged
sula7 referenced this issue Jul 19, 2019
Corrected mistakes in func ChangeGroupTimeZone
9a374ce 
1. Mistake was in Length of MessageEntity, I used 8 instad of 9, missing whitespace in file commands_test.go 2. According to PR, removed TrimSpace() in commands.go Now, tests pass
anatoliyfedorenko added a commit that referenced this issue Jul 19, 2019
@anatoliyfedorenko
Merge pull request #55 from maddevsio/testing
c4720e2 
Add test in commands_test.go #54
@sula7
Copy link
Contributor

sula7 commented Jul 19, 2019

Test cases if no standuper and incorrect timezone entered of ChangeGroupTimeZone() and ChangeUserTimeZone()

sula7 pushed a commit that referenced this issue Jul 19, 2019
Added TestChangeUserTimeZone() in commands_test.go #54
4b9aef3 
Test creates a standuper changes his timezone from group's default to user's custom. Also in ChangeUserTimeZone of commands.go if no MessageEntity text timezone changes to default (Asia/Bishkek)
sula7 referenced this issue Jul 19, 2019
Added test in commands_test.go for incorrect cases
2dfd3b2 
Test for ChangeGroupTimeZone() in case of incorrect timezone entered. Test for ChangeUserTimeZone() in case of user is not a standuper and incorrect timezone entered
@sula7 sula7 mentioned this issue Jul 22, 2019
Merged
@sula7 sula7 self-assigned this Jul 23, 2019
@anatoliyfedorenko anatoliyfedorenko added the help wanted Extra attention is needed label Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anatoliyfedorenko @sula7