[CPAN-RT #72015] Last OID not returned by find_next_oid() (Pascal Ber…

…inguie).
maddingue · Nov 14, 2012 · f5008e1 · f5008e1
1 parent c549cfb
commit f5008e1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/Changes b/Changes
@@ -1,6 +1,7 @@
 Revision history for SNMP-ToolBox
 
         [BUGFIX] CPAN-RT #72315: Avoid a warning in _by_oid_classical (Elizabeth Cholet).
+        [BUGFIX] CPAN-RT #72015: Last OID not returned by find_next_oid() (Pascal Beringuie).
 
 0.02    2011.08.12
         [BUGFIX] Avoid a warning in find_next_oid().

diff --git a/lib/SNMP/ToolBox.pm b/lib/SNMP/ToolBox.pm
@@ -80,7 +80,7 @@ sub find_next_oid {
     }
 
     # get the entry following the requested one
-    my $next_oid = (defined $next_oid_idx and $next_oid_idx < $#{$oid_list})
+    my $next_oid = (defined $next_oid_idx and $next_oid_idx <= $#{$oid_list})
                  ? $oid_list->[$next_oid_idx]
                  : "NONE";
 

diff --git a/t/30-find_next_oid.t b/t/30-find_next_oid.t
@@ -41,6 +41,9 @@ my @cases = (
     [ "called with a request within the list, with no context",
         [ $oid_list[4] ], $oid_list[5] ],
 
+    [ "called with a request just before the end of the list, with no context",
+        [ $oid_list[-2] ], $oid_list[-1] ],
+
     [ "called with a request outside the list, with no context",
         [ "$base_oid.5" ], "NONE" ],