Real URLs #4
Merged
Real URLs #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check status * If READY, play stream * If 404, then tune channel and start polling status * Once status is READY, play channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the frontend functionality. Instead of tuning the channel when you click it and then redirecting, it just follows the URL to the channel like it should.
When the channel view is loaded, status is checked immediately and the appropriate things will happen.
This means URLs are working like they should. You should be able to link to or go directly to a channel and shit should just work.
This is the new flow after the channel view is loaded:
READY, the player will start playing the stream404, the channel will be tuned and the page will start polling the status of the channel to check if its ready to stream.